From: Rich Johnston <rjohnston@sgi.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>, ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] xfstests: fix src/seek_sanity_test -t option
Date: Tue, 28 May 2013 10:57:22 -0500 [thread overview]
Message-ID: <51A4D3E2.3020204@sgi.com> (raw)
In-Reply-To: <519EF4AE.60702@redhat.com>
On 05/24/2013 12:03 AM, Eric Sandeen wrote:
> _require_seek_data_hole() does not work because
> the -t (test) option of seek_sanity_test is broken,
> because of an early check for (argc != 2):
>
> # src/seek_sanity_test -t foo
> Usage: src/seek_sanity_test base_file_path
>
> So _require_seek_data_hole() doesn't see the
> "Kernel does not support" string it's looking for,
> and passes the check.
>
> So rather than _notrun-ing the test, it proceeds to
> fail with noisy errors.
>
> Fix that, make a common usage() function, and check for
> too many args as well.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Thanks, this has been committed:
commit bd13bf9e2a87a40d3aab2644967029b854ed2d11
Author: Eric Sandeen <sandeen@redhat.com>
Date: Tue May 28 10:37:39 2013 -0500
xfstests: fix src/seek_sanity_test -t option
--Rich
prev parent reply other threads:[~2013-05-28 15:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 5:03 [PATCH] xfstests: fix src/seek_sanity_test -t option Eric Sandeen
2013-05-24 5:14 ` [PATCH V2] " Eric Sandeen
2013-05-24 6:54 ` Jeff Liu
2013-05-24 8:02 ` Zheng Liu
2013-05-28 15:57 ` Rich Johnston [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A4D3E2.3020204@sgi.com \
--to=rjohnston@sgi.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).