From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] e2fsprogs FTBFS: allocate inode table wholly within group
Date: Thu, 04 Jul 2013 10:19:27 -0400 [thread overview]
Message-ID: <51D5846F.10400@redhat.com> (raw)
In-Reply-To: <51D3269B.5080608@redhat.com>
On 7/2/13 3:14 PM, Eric Sandeen wrote:
> Building e2fsprogs 1.42.8 on ppc, I got this:
>
> r_1024_small_bg: ext2 1024 blocksize with small block groups: failed
You can add a RH FTBFS bug to the commit now if you like,
[Bug 980519] New: FTBFS: self checks failure: Tests failed: r_1024_small_bg
https://bugzilla.redhat.com/show_bug.cgi?id=980519
since Karsten Hopp has now reported it for Rawhide as well.
-Eric
> Because during the resize step it did this:
>
> Itable move group 1 block 1030->1092 (diff 62)
>
> but during e2fsck it found:
>
> /tmp/e2fsprogs-tmp.uiFhgP: Inode table for group 1 is not in group. (block 1092)
>
> i.e. from dumpe2fs we can see:
>
> Group 1: (Blocks 1025-1110)
> Backup superblock at 1025, Group descriptors at 1026-1026
> Block bitmap at 1090 (+65), Inode bitmap at 1091 (+66)
> Inode table at 1092-1123 (+67)
> ^^^^ beyond end of block group
>
> ext2fs_allocate_group_table() currently sends the last block of the
> group as an acceptable *starting* point for the inode table allocation.
>
> Because the inode table may be several blocks, and must reside wholly
> within the group, move the last acceptable starting block back by this
> amount so that the allocated range cannot extend past the end of the
> group.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> p.s. I *think* this fixes it; I've not convinced myself that the failure
> is 100% deterministic, so extra eyeballs on the patch are welcome.
>
> Thanks,
> -Eric
>
> Index: e2fsprogs-1.42.8/lib/ext2fs/alloc_tables.c
> ===================================================================
> --- e2fsprogs-1.42.8.orig/lib/ext2fs/alloc_tables.c
> +++ e2fsprogs-1.42.8/lib/ext2fs/alloc_tables.c
> @@ -200,6 +200,9 @@ errcode_t ext2fs_allocate_group_table(ex
> }
>
> if (!ext2fs_inode_table_loc(fs, group)) {
> + /* Inode table must fit within group, so adjust last blk */
> + last_blk -= (fs->inode_blocks_per_group - 1);
> +
> retval = ext2fs_get_free_blocks2(fs, group_blk, last_blk,
> fs->inode_blocks_per_group,
> bmap, &new_blk);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-07-04 14:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 19:14 [PATCH] e2fsprogs: allocate inode table wholly within group Eric Sandeen
2013-07-04 14:19 ` Eric Sandeen [this message]
2013-07-07 15:53 ` Theodore Ts'o
2013-07-07 23:34 ` Theodore Ts'o
2013-07-08 1:59 ` Eric Sandeen
2013-07-08 18:34 ` Eric Sandeen
2013-07-08 21:27 ` Eric Sandeen
2013-10-01 1:57 ` Theodore Ts'o
2013-10-01 3:59 ` [PATCH 1/4] resize2fs: add debugging support for resize2fs -M calcuations Theodore Ts'o
2013-10-01 3:59 ` [PATCH 2/4] resize2fs: fix -M size calculations to avoid cutting off the inode table Theodore Ts'o
2013-10-01 3:59 ` [PATCH 3/4] resize2fs: relocate inode table blocks if necessary when shrinking Theodore Ts'o
2013-10-01 3:59 ` [PATCH 4/4] tests: add test for resize2fs -M with inode table in middle of block group Theodore Ts'o
2013-10-01 15:26 ` [PATCH] e2fsprogs: allocate inode table wholly within group Eric Sandeen
2013-10-01 15:35 ` Eric Sandeen
2013-10-01 16:29 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D5846F.10400@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).