From: Jeff Mahoney <jeffm@suse.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
Greg KH <gregkh@linux.com>
Subject: Re: [PATCH 2/2] ext4: use kobj_completion in ext4_sb_info
Date: Wed, 11 Sep 2013 21:52:18 -0400 [thread overview]
Message-ID: <52311E52.4040001@suse.com> (raw)
In-Reply-To: <20130912014813.GA12918@thunk.org>
[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]
On 9/11/13 9:48 PM, Theodore Ts'o wrote:
> On Tue, Sep 10, 2013 at 01:44:13PM -0400, Jeff Mahoney wrote:
>> Now that we have the kobj_completion structure available, let's use it
>> in ext4.
>>
>> Note that we aggregate the del/put/wait_for_completion in one
>> kobj_completion_del_and_wait call. Since the kobject isn't used for
>> anything while the fs is shutting down and we wait until it's released
>> before continuing anyway, this is safe.
>>
>> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
>
> I don't have a huge objection to this, but given that it's not fixing
> a bug, and it's not saving _that_ many lines of code, if you want to
> run the first patch through Greg's tree (which is fine with me), I
> might wait to merge this patch until 3.13, so it's not obvious that
> it's worth dealing with the inter-tree dependency, since it
> complicates testing on my end.
>
> Does that sound reasonable?
Works for me. The ext4 case isn't something I'm in a huge rush to get in
-- it was just the most obvious (to me) existing users of the
kobj/completion pair.
-Jeff
--
Jeff Mahoney
SUSE Labs
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 841 bytes --]
prev parent reply other threads:[~2013-09-12 1:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 17:44 [PATCH 2/2] ext4: use kobj_completion in ext4_sb_info Jeff Mahoney
2013-09-12 1:48 ` Theodore Ts'o
2013-09-12 1:52 ` Jeff Mahoney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52311E52.4040001@suse.com \
--to=jeffm@suse.com \
--cc=gregkh@linux.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).