From: Eric Sandeen <sandeen@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger@whamcloud.com>,
linux-ext4@vger.kernel.org, Niu Yawei <niu@whamcloud.com>
Subject: Re: quota: fix disabling quota, add quota tests
Date: Fri, 18 Oct 2013 10:23:06 -0500 [thread overview]
Message-ID: <5261525A.9060301@redhat.com> (raw)
In-Reply-To: <20131014135528.GA4685@thunk.org>
On 10/14/13 8:55 AM, Theodore Ts'o wrote:
> On Tue, Jan 22, 2013 at 05:00:48PM -0700, Andreas Dilger wrote:
>> From: Niu Yawei <niu@whamcloud.com>
>>
>> Update all superblock copies when disabling the quota feature.
>>
>> Added basic tests for the quota feature.
>>
>> Signed-off-by: Niu Yawei <niu@whamcloud.com>
>> Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
>
> Applied, thanks.
This actually breaks things (or seems to, I haven't chased it all
down; quota stuff is busted, anyway):
# git clone git://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git
# cd e2fsprogs
# git checkout next
# ./configure
# make
...
make[2]: Entering directory `/tmp/e2fsprogs/e2fsck'
...
CC prof_err.c
CC logfile.c
CC sigcatcher.c
make[2]: *** No rule to make target `../lib/libquota.a', needed by `e2fsck'. Stop.
make[2]: Leaving directory `/tmp/e2fsprogs/e2fsck'
make[1]: *** [all-progs-recursive] Error 1
make[1]: Leaving directory `/tmp/e2fsprogs'
make: *** [all] Error 2
"make clean" doesn't remove lib/libquota.a (nor does git clean -f -d thanks
to .gitignore (?)) so old builds pretend to be ok.
Using QUOTA_CMT on lib requirements might work but it's hacky, it'd mean
the LIBQUOTA stuff has to be last on the line, and if we ever have more than
1 configurable lib, then what?
-Eric
prev parent reply other threads:[~2013-10-18 15:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 0:00 [PATCH] quota: fix disabling quota, add quota tests Andreas Dilger
2013-01-23 0:09 ` Andreas Dilger
2013-10-14 13:55 ` Theodore Ts'o
2013-10-18 15:23 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5261525A.9060301@redhat.com \
--to=sandeen@redhat.com \
--cc=adilger@whamcloud.com \
--cc=linux-ext4@vger.kernel.org \
--cc=niu@whamcloud.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).