linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tao Ma <tm@tao.ma>
To: Boxi Liu <boxi10liu@gmail.com>
Cc: Theodore Tso <tytso@mit.edu>,
	"lewis.liulei" <lewis.liulei@huawei.com>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
	Robin Dong <sanbai@taobao.com>
Subject: Re: fix the ext4_read_inline_dir return value
Date: Tue, 22 Oct 2013 10:10:27 +0800	[thread overview]
Message-ID: <5265DE93.8060406@tao.ma> (raw)
In-Reply-To: <CAAFszuV7tXpGA5GVWtLzzHZayPgN-M+n_W4LN67i=ueicfZb+Q@mail.gmail.com>

Hi Boxi,
On 10/22/2013 12:33 AM, Boxi Liu wrote:
> hi，
> there may be a bug in ext4_read_inline_dir() function with inline_data feature.
> when I recursion call a sys_old_readdir to read a direntry's
> sub_dentry,I find that the ext4_read_inline_dir return the len of the
> inline_data ,but in the no inline_data case,it will return 0.It is
> inconsistent.
> So I try to make a patch to fix it.
The fix looks good to me an you can add
Acked-by: Tao Ma <boyu.mt@taobao.com>

But next time please generate the patch with git format-patch and send
it using git send-email.

Thanks,
Tao
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2013-10-22  2:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21 16:33 fix the ext4_read_inline_dir return value Boxi Liu
2013-10-21 17:35 ` jon ernst
2013-10-22  2:10 ` Tao Ma [this message]
2013-10-30 12:13   ` Theodore Ts'o
2013-10-31  2:34     ` Tao Ma
  -- strict thread matches above, loose matches on Subject: below --
2013-09-17 15:08 Boxi Liu
2013-09-17 16:29 ` Jan Kara
2013-09-17 17:30   ` Boxi Liu
2013-09-17 17:38     ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5265DE93.8060406@tao.ma \
    --to=tm@tao.ma \
    --cc=boxi10liu@gmail.com \
    --cc=lewis.liulei@huawei.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sanbai@taobao.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).