From: Randy Dunlap <rdunlap@infradead.org>
To: David Gow <davidgow@google.com>,
Brendan Higgins <brendanhiggins@google.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Shuah Khan <skhan@linuxfoundation.org>,
Iurii Zaikin <yzaikin@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Matthieu Baerts <matthieu.baerts@tessares.net>,
linux-ext4@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it
Date: Wed, 21 Oct 2020 14:30:53 -0700 [thread overview]
Message-ID: <52959e99-4105-3de9-730c-c46894b82bdd@infradead.org> (raw)
In-Reply-To: <CABVgOSmRbZqDw83f1Z14nSSVQTeFOvyehXhB=NnbaaANrwe=FQ@mail.gmail.com>
On 10/21/20 2:29 PM, David Gow wrote:
> On Thu, Oct 22, 2020 at 5:15 AM Brendan Higgins
> <brendanhiggins@google.com> wrote:
>>
>> On Tue, Oct 20, 2020 at 12:37 AM Geert Uytterhoeven
>> <geert@linux-m68k.org> wrote:
>>>
>>> EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the
>>> user may not want to enable. Fix this by making the test depend on
>>> EXT4_FS instead.
>>>
>>> Fixes: 1cbeab1b242d16fd ("ext4: add kunit test for decoding extended timestamps")
>>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>
>> If I remember correctly, having EXT4_KUNIT_TESTS select EXT4_FS was
>> something that Ted specifically requested, but I don't have any strong
>> feelings on it either way.
>
> For what it's worth, the upcoming FAT filesystem tests[1] are also
> select-ing FAT_FS at the moment, so if this changes here, I'll likely
> update it there as well.
>
> -- David
>
> [1]: https://lore.kernel.org/linux-kselftest/20201021061713.1545931-1-davidgow@google.com/T/#u
>
then hopefully both get updated. This is just backwards.
--
~Randy
prev parent reply other threads:[~2020-10-21 21:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 7:37 [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it Geert Uytterhoeven
2020-10-21 21:15 ` Brendan Higgins
2020-10-21 21:16 ` Randy Dunlap
2020-10-21 22:36 ` Theodore Y. Ts'o
2020-10-21 23:07 ` Randy Dunlap
2020-10-22 3:43 ` Theodore Y. Ts'o
2020-10-22 3:55 ` Randy Dunlap
2020-10-22 7:20 ` Geert Uytterhoeven
2020-10-22 23:52 ` Brendan Higgins
2020-10-23 14:07 ` Theodore Y. Ts'o
2020-10-24 5:53 ` David Gow
2020-10-21 21:29 ` David Gow
2020-10-21 21:30 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52959e99-4105-3de9-730c-c46894b82bdd@infradead.org \
--to=rdunlap@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=geert@linux-m68k.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthieu.baerts@tessares.net \
--cc=pabeni@redhat.com \
--cc=skhan@linuxfoundation.org \
--cc=tytso@mit.edu \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).