From: Eric Sandeen <sandeen@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 08/10] debugfs: remove dead code
Date: Tue, 07 Jan 2014 11:14:39 -0600 [thread overview]
Message-ID: <52CC35FF.8000302@redhat.com> (raw)
In-Reply-To: <1389106394-31898-8-git-send-email-tytso@mit.edu>
On 1/7/14, 8:53 AM, Theodore Ts'o wrote:
> Addresses-Coverity-Id: #1138573
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
FWIW, Darrick had already sent this as part of
"[PATCH 1/2] misc: fix resource leaks in e2fsprogs"
- but I suppose small targeted patches are better.
-Eric
> ---
> debugfs/debugfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
> index 998af33..0e56ead 100644
> --- a/debugfs/debugfs.c
> +++ b/debugfs/debugfs.c
> @@ -289,8 +289,6 @@ void do_init_filesys(int argc, char **argv)
> if (err)
> return;
> ext2fs_blocks_count_set(¶m, blocks);
> - if (err)
> - return;
> retval = ext2fs_initialize(argv[1], 0, ¶m,
> unix_io_manager, ¤t_fs);
> if (retval) {
>
next prev parent reply other threads:[~2014-01-07 17:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 14:53 [PATCH 01/10] e2fsck: release allocated memory on error or abort in e2fsck_pass1() Theodore Ts'o
2014-01-07 14:53 ` [PATCH 02/10] libext2fs: make ext2fs_group_desc_csum return 0 if meta_csum not enabled Theodore Ts'o
2014-01-07 14:53 ` [PATCH 03/10] e2fsck: fix memory leak on error path in read_bad_blocks_files() Theodore Ts'o
2014-01-07 14:53 ` [PATCH 04/10] libext2fs: remove redundant code in rb_print_stats() Theodore Ts'o
2014-01-07 14:53 ` [PATCH 05/10] libquota: add error checking to quota_write_inode() Theodore Ts'o
2014-01-07 14:53 ` [PATCH 06/10] libquota: add error checking to quota_remove_inode Theodore Ts'o
2014-01-07 14:53 ` [PATCH 07/10] libext2fs: fix memory leaks on error paths in ext2fs_create_icount_tdb Theodore Ts'o
2014-01-07 14:53 ` [PATCH 08/10] debugfs: remove dead code Theodore Ts'o
2014-01-07 17:14 ` Eric Sandeen [this message]
2014-01-07 17:25 ` Theodore Ts'o
2014-01-07 18:58 ` Darrick J. Wong
2014-01-07 14:53 ` [PATCH 09/10] badblocks: print warning if set_o_direct() fails Theodore Ts'o
2014-01-07 14:53 ` [PATCH 10/10] libss: fix memory leak if realloc() fails in ss_parse() Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CC35FF.8000302@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).