From: Robert Yang <liezhi.yang@windriver.com>
To: Darren Hart <dvhart@linux.intel.com>, <tytso@mit.edu>
Cc: <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH V4 00/11] 2fsprogs/mke2fs: add an option: -d root-directory
Date: Thu, 6 Mar 2014 17:39:56 +0800 [thread overview]
Message-ID: <5318426C.50105@windriver.com> (raw)
In-Reply-To: <CF3D6C67.74AD8%dvhart@linux.intel.com>
On 03/06/2014 04:21 PM, Darren Hart wrote:
> On 3/1/14, 0:06, "Robert Yang" <liezhi.yang@windriver.com> wrote:
>
>> * Changes of V4:
>> - Rebase to the up to date master branch
>> - Fix the skip of socket file (break -> continue)
>
> Robert,
>
> Thanks for taking the time to rebase these again. I don't have anything to
> add to my existing Reviewed-by's. We'd love to see this merged as we're
> currently having to work around issues with gen2extfs in the Yocto Project
> and we'd prefer to use upstream e2fsprogs/mke2fs. I think Robert has
> addressed all the issues that have been raised.
>
Yes, I think so, and we have used the "mke2fs -d" option in WR Linux for
more than half a year, didn't meet any obvious errors.
// Robert
> Are there any additional concerns?
>
> Thanks everyone for your time in reviewing,
>
> Darren
>
>>
>> * Changes of V3:
>> - __FUNCTION__ -> __func__
>> - Rebase to the up to date master branch
>>
>> * Changes of V2:
>> - Add the "-d" option when the code is ready rather than add it in the
>> first commit.
>> - Remove "name = name"
>> - func_name -> __FUNCTION__
>> - The size impact on mke2fs:
>> a) Not stripped:
>> 1,837,440 -> 1,903,522 (64K increased)
>> b) Stripped:
>> 329,464 -> 321,272 (8K increased)
>> No impact on tune2fs
>>
>> * Changes from the RFC patches:
>> - Move the common code of debugfs and mke2fs to misc/create_inode.c to
>> avoid bloating the tune2fs binary
>> - Fix the error of "make check"
>> - Rebase to the up to date master branch
>>
>> // Robert
>>
>> Robert Yang (11):
>> mke2fs: add the ability to copy files from a given directory
>> misc/create_inode.c: copy files recursively
>> misc/create_inode.c: create special file
>> misc/create_inode.c: create symlink
>> misc/create_inode.c: copy regular file
>> misc/create_inode.c: create directory
>> misc/create_inode.c: set owner/mode/time for the inode
>> mke2fs.c: add an option: -d root-directory
>> misc/create_inode.c: handle hardlinks
>> debugfs: use the functions in misc/create_inode.c
>> mke2fs.8.in: update the manual for the -d option
>>
>> debugfs/Makefile.in | 17 +-
>> debugfs/debugfs.c | 305 ++-------------------------
>> debugfs/debugfs.h | 1 +
>> misc/Makefile.in | 13 +-
>> misc/create_inode.c | 574
>> +++++++++++++++++++++++++++++++++++++++++++++++++++
>> misc/create_inode.h | 35 ++++
>> misc/mke2fs.8.in | 7 +
>> misc/mke2fs.c | 43 +++-
>> 8 files changed, 690 insertions(+), 305 deletions(-)
>> create mode 100644 misc/create_inode.c
>> create mode 100644 misc/create_inode.h
>>
>> --
>> 1.7.10.4
>>
>>
>
>
next prev parent reply other threads:[~2014-03-06 9:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-01 8:06 [PATCH V4 00/11] 2fsprogs/mke2fs: add an option: -d root-directory Robert Yang
2014-03-01 8:06 ` [PATCH V4 01/11] mke2fs: add the ability to copy files from a given directory Robert Yang
2014-03-01 8:06 ` [PATCH V4 02/11] misc/create_inode.c: copy files recursively Robert Yang
2014-03-01 8:06 ` [PATCH V4 03/11] misc/create_inode.c: create special file Robert Yang
2014-03-01 8:06 ` [PATCH V4 04/11] misc/create_inode.c: create symlink Robert Yang
2014-03-01 8:06 ` [PATCH V4 05/11] misc/create_inode.c: copy regular file Robert Yang
2014-03-06 19:06 ` Darrick J. Wong
2014-03-06 19:47 ` Theodore Ts'o
2014-03-06 20:14 ` Darrick J. Wong
2014-03-06 22:57 ` Theodore Ts'o
2014-03-07 1:24 ` Robert Yang
2014-03-07 2:56 ` Darrick J. Wong
2014-03-07 3:22 ` Robert Yang
2014-03-07 2:38 ` Darrick J. Wong
2014-03-01 8:06 ` [PATCH V4 06/11] misc/create_inode.c: create directory Robert Yang
2014-03-01 8:06 ` [PATCH V4 07/11] misc/create_inode.c: set owner/mode/time for the inode Robert Yang
2014-03-01 8:06 ` [PATCH V4 08/11] mke2fs.c: add an option: -d root-directory Robert Yang
2014-03-01 8:06 ` [PATCH V4 09/11] misc/create_inode.c: handle hardlinks Robert Yang
2014-03-01 8:06 ` [PATCH V4 10/11] debugfs: use the functions in misc/create_inode.c Robert Yang
2014-03-01 8:06 ` [PATCH V4 11/11] mke2fs.8.in: update the manual for the -d option Robert Yang
2014-03-06 8:21 ` [PATCH V4 00/11] 2fsprogs/mke2fs: add an option: -d root-directory Darren Hart
2014-03-06 9:39 ` Robert Yang [this message]
2014-03-06 16:30 ` Theodore Ts'o
2014-03-07 2:51 ` Robert Yang
2014-03-07 2:59 ` Darrick J. Wong
2014-03-07 3:24 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5318426C.50105@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=dvhart@linux.intel.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).