From: Robert Yang <liezhi.yang@windriver.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>,
"Theodore Ts'o" <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] create_inode: fix gcc -Wall complaints
Date: Wed, 12 Mar 2014 14:34:48 +0800 [thread overview]
Message-ID: <53200008.60107@windriver.com> (raw)
In-Reply-To: <531FFFBD.1010503@windriver.com>
On 03/12/2014 02:33 PM, Robert Yang wrote:
>
>
> On 03/12/2014 11:48 AM, Darrick J. Wong wrote:
>> On Tue, Mar 11, 2014 at 11:45:39PM -0400, Theodore Ts'o wrote:
>>> On Tue, Mar 11, 2014 at 11:41:10PM -0400, Theodore Ts'o wrote:
>>>> We had several functions that were not returning zero on success. Fix
>>>> this.
>>>>
>>>> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
>>>
>>> One additional gcc -Wall nit which I have not yet fixed:
>>>
>>> create_inode.c is using ext2fs_inline_data_init() which is currently a
>>> private function defined in ext2fsP.h.
>>>
>>> We either need to make this a publically exported interface (in which
>>> case we have to guarantee that it is stable), or we need to find
>>> another way to make the right thing happen here.
>>>
>>> Darrick, Robert, do you have any thoughts or suggestions?
>>
>> I fixed that up in the cppcheck cleanups patch by moving those declarations to
>> ext2fs.h. Maybe I should have shoved the patch closer to the head.
>>
>
> He Darrick and Ted,
>
s/He/Hi/
Sorry for the typo.
// Robert
>
> Thank you very much!
>
> // Robert
>
>> --D
>>>
>>> - Ted
>>>
>>> P.S. My bad for not doing a gcc -Wall run on the patches before
>>> accepting them. And in the future, I'd appreciate it if people who
>>> are preparing patches do a "make gcc-wall" and make sure you're not
>>> making things worse. There are plenty of bugs that can be turned up
>>> this way.
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2014-03-12 6:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 3:41 [PATCH] create_inode: fix gcc -Wall complaints Theodore Ts'o
2014-03-12 3:45 ` Theodore Ts'o
2014-03-12 3:48 ` Darrick J. Wong
2014-03-12 6:33 ` Robert Yang
2014-03-12 6:34 ` Robert Yang [this message]
2014-03-12 14:32 ` Theodore Ts'o
2014-03-12 17:59 ` Darrick J. Wong
2014-03-12 20:02 ` Darrick J. Wong
2014-03-12 20:51 ` Theodore Ts'o
2014-03-13 2:21 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53200008.60107@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).