* [PATCH] ext3: explicitly remove inode from orphan list after failed direct_io
@ 2010-02-26 13:05 Dmitry Monakhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Monakhov @ 2010-02-26 13:05 UTC (permalink / raw)
To: linux-ext4; +Cc: jack, Dmitry Monakhov
Otherwise non empty orphan list will be triggered on umount.
Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
fs/ext3/inode.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index cf0e3aa..2522106 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -1818,6 +1818,9 @@ retry:
* but cannot extend i_size. Bail out and pretend
* the write failed... */
ret = PTR_ERR(handle);
+ if (inode->i_nlink)
+ ext3_orphan_del(NULL, inode);
+
goto out;
}
if (inode->i_nlink)
--
1.6.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ext3: explicitly remove inode from orphan list after failed direct io
@ 2014-03-17 19:13 Eric Sandeen
2014-03-17 19:22 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Eric Sandeen @ 2014-03-17 19:13 UTC (permalink / raw)
To: ext4 development; +Cc: Jan Kara
Otherwise non-empty orphan list will be triggered on umount.
This is just an application of commit da1daf by Dmitry Monakhov
to the same code in ext3.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index 384b6eb..caf4c4a 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -1925,6 +1925,8 @@ retry:
* and pretend the write failed... */
ext3_truncate_failed_direct_write(inode);
ret = PTR_ERR(handle);
+ if (inode->i_nlink)
+ ext3_orphan_del(NULL, inode);
goto out;
}
if (inode->i_nlink)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext3: explicitly remove inode from orphan list after failed direct io
2014-03-17 19:13 [PATCH] ext3: explicitly remove inode from orphan list after failed direct io Eric Sandeen
@ 2014-03-17 19:22 ` Jan Kara
0 siblings, 0 replies; 3+ messages in thread
From: Jan Kara @ 2014-03-17 19:22 UTC (permalink / raw)
To: Eric Sandeen; +Cc: ext4 development, Jan Kara
On Mon 17-03-14 14:13:00, Eric Sandeen wrote:
> Otherwise non-empty orphan list will be triggered on umount.
>
> This is just an application of commit da1daf by Dmitry Monakhov
> to the same code in ext3.
Thanks, I've merged the patch.
Honza
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
> index 384b6eb..caf4c4a 100644
> --- a/fs/ext3/inode.c
> +++ b/fs/ext3/inode.c
> @@ -1925,6 +1925,8 @@ retry:
> * and pretend the write failed... */
> ext3_truncate_failed_direct_write(inode);
> ret = PTR_ERR(handle);
> + if (inode->i_nlink)
> + ext3_orphan_del(NULL, inode);
> goto out;
> }
> if (inode->i_nlink)
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-17 19:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-17 19:13 [PATCH] ext3: explicitly remove inode from orphan list after failed direct io Eric Sandeen
2014-03-17 19:22 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2010-02-26 13:05 [PATCH] ext3: explicitly remove inode from orphan list after failed direct_io Dmitry Monakhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).