e2fsprogs: mke2fs -d: copy the Extended Attributes

e2fsprogs: mke2fs -d: copy the Extended Attributes

[Robert Yang]

Hi Ted,

The "mke2fs -d" doesn't copy the file's extended attributes into the
device currently, I'd like to make it work and submit a patch for it
if it is acceptable by e2fsprogs. Maybe we can add a "[-x xattr]"
option for "mke2fs -d" to make it copy the extended attributes.

What's your opinion, please ?

-- 
Thanks

Robert

Re: e2fsprogs: mke2fs -d: copy the Extended Attributes

[Theodore Ts'o]

On Thu, Apr 17, 2014 at 03:14:34PM +0800, Robert Yang wrote:
> 
> The "mke2fs -d" doesn't copy the file's extended attributes into the
> device currently, I'd like to make it work and submit a patch for it
> if it is acceptable by e2fsprogs. Maybe we can add a "[-x xattr]"
> option for "mke2fs -d" to make it copy the extended attributes.

Any reason not to always copy the xattrs if they exist?

If we want to add a new option for a feature like this which is fairly
exotic, my preference would be to either use the -E mechanism and make
it be an extended option, or to put it in /etc/mke2fs.conf.

Regards,

						- Ted

Re: e2fsprogs: mke2fs -d: copy the Extended Attributes

[Robert Yang]

On 04/18/2014 12:27 AM, Theodore Ts'o wrote:
> On Thu, Apr 17, 2014 at 03:14:34PM +0800, Robert Yang wrote:
>>
>> The "mke2fs -d" doesn't copy the file's extended attributes into the
>> device currently, I'd like to make it work and submit a patch for it
>> if it is acceptable by e2fsprogs. Maybe we can add a "[-x xattr]"
>> option for "mke2fs -d" to make it copy the extended attributes.
>
> Any reason not to always copy the xattrs if they exist?
>
> If we want to add a new option for a feature like this which is fairly
> exotic, my preference would be to either use the -E mechanism and make
> it be an extended option, or to put it in /etc/mke2fs.conf.

Thanks for the reply, yes, add the new option "[-x xattr]" sounds
strange, I will try to use the -E mechanism and make it be an
extended option.

Have a good day, I have to go to sleep now.

// Robert

>
> Regards,
>
> 						- Ted
>
>

Re: e2fsprogs: mke2fs -d: copy the Extended Attributes

[Robert Yang]

On 04/18/2014 01:33 AM, Robert Yang wrote:
>
>
> On 04/18/2014 12:27 AM, Theodore Ts'o wrote:
>> On Thu, Apr 17, 2014 at 03:14:34PM +0800, Robert Yang wrote:
>>>
>>> The "mke2fs -d" doesn't copy the file's extended attributes into the
>>> device currently, I'd like to make it work and submit a patch for it
>>> if it is acceptable by e2fsprogs. Maybe we can add a "[-x xattr]"
>>> option for "mke2fs -d" to make it copy the extended attributes.
>>
>> Any reason not to always copy the xattrs if they exist?

Always copy the xattrs if they exist also sounds reasonable, I will try
to investigate more usecases.

// Robert

>>
>> If we want to add a new option for a feature like this which is fairly
>> exotic, my preference would be to either use the -E mechanism and make
>> it be an extended option, or to put it in /etc/mke2fs.conf.
>
> Thanks for the reply, yes, add the new option "[-x xattr]" sounds
> strange, I will try to use the -E mechanism and make it be an
> extended option.
>
> Have a good day, I have to go to sleep now.
>
> // Robert
>
>>
>> Regards,
>>
>>                         - Ted
>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>