From: Niu Yawei <yawei.niu@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
yawei.niu@intel.com, andreas.dilger@intel.com,
lai.siyao@intel.com
Subject: [PATCH 4/5] quota: missing lock in dqcache_shrink_scan()
Date: Wed, 04 Jun 2014 12:22:13 +0800 [thread overview]
Message-ID: <538E9EF5.40806@gmail.com> (raw)
In-Reply-To: <20140603154301.GE30706@quack.suse.cz>
dqcache_shrink_scan() should use dq_list_lock to protect the
scan on free_dquots list.
Signed-off-by: Niu Yawei <yawei.niu@intel.com>
---
fs/quota/dquot.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index 51b5763..a94d464 100644
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -702,6 +702,7 @@ dqcache_shrink_scan(struct shrinker *shrink, struct shrink_control *sc)
struct dquot *dquot;
unsigned long freed = 0;
+ spin_lock(&dq_list_lock);
head = free_dquots.prev;
while (head != &free_dquots && sc->nr_to_scan) {
dquot = list_entry(head, struct dquot, dq_free);
@@ -713,6 +714,7 @@ dqcache_shrink_scan(struct shrinker *shrink, struct shrink_control *sc)
freed++;
head = free_dquots.prev;
}
+ spin_unlock(&dq_list_lock);
return freed;
}
--
1.7.1
next prev parent reply other threads:[~2014-06-04 4:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 10:47 [PATCH] quota: remove dqptr_sem for scalability Niu Yawei
2014-05-22 13:25 ` Jan Kara
2014-05-23 3:37 ` Niu Yawei
2014-05-27 10:13 ` [PATCH 2/3] quota: avoid unnecessary dqget()/dqput() calls Niu Yawei
2014-05-27 10:15 ` [PATCH 3/3] quota: remove dqptr_sem Niu Yawei
2014-05-23 4:02 ` [PATCH] quota: remove dqptr_sem for scalability Eric Sandeen
2014-05-23 5:22 ` Niu Yawei
2014-05-23 13:02 ` Eric Sandeen
2014-05-27 10:10 ` [PATCH 1/3] quota: protect Q_GETFMT by dqonoff_mutex Niu Yawei
2014-05-27 10:12 ` Christoph Hellwig
2014-05-27 10:28 ` Niu Yawei
2014-05-28 1:52 ` [PATCH 1/3 v2] " Niu Yawei
2014-06-02 7:32 ` Jan Kara
2014-05-28 1:53 ` [PATCH 2/3 v2] quota: avoid unnecessary dqget()/dqput() calls Niu Yawei
2014-06-02 7:42 ` Jan Kara
2014-05-28 1:55 ` [PATCH 3/3 v2] quota: remove dqptr_sem Niu Yawei
2014-05-28 2:01 ` Niu Yawei
2014-06-02 8:34 ` Jan Kara
2014-06-03 9:51 ` Niu Yawei
2014-06-03 15:43 ` Jan Kara
2014-06-04 4:19 ` [PATCH 1/5] quota: protect Q_GETFMT by dqonoff_mutex Niu Yawei
2014-06-04 15:36 ` Jan Kara
2014-06-04 4:20 ` [PATCH 2/5] quota: avoid unnecessary dqget()/dqput() calls Niu Yawei
2014-06-04 4:21 ` [PATCH 3/5] quota: simplify remove_inode_dquot_ref() Niu Yawei
2014-06-04 4:22 ` Niu Yawei [this message]
2014-06-04 4:23 ` [PATCH 5/5] quota: remove dqptr_sem Niu Yawei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538E9EF5.40806@gmail.com \
--to=yawei.niu@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=lai.siyao@intel.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=yawei.niu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).