Re: [PATCH] e2fsprogs: Add INCLUDES to BUILD_CFLAGS when cross-compiling

Theodore Ts'o
2014-07-05T23:55:47Z

On Tue, Jun 03, 2014 at 06:51:59PM -0300, Gustavo Zacarias wrote:
> We need $INCLUDES in BUILD_CFLAGS otherwise cross-compilation is broken
> now that util/subst.c uses config.h (from commit 2873927d15).
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
> configure.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.in b/configure.in
> index 448a292..8bac870 100644
> --- a/configure.in
> +++ b/configure.in
> @@ -1382,7 +1382,7 @@ if test $cross_compiling = no; then
> BUILD_CFLAGS="$CFLAGS $CPPFLAGS $INCLUDES -DHAVE_CONFIG_H"
> BUILD_LDFLAGS="$LDFLAGS"
> else
> - BUILD_CFLAGS=
> + BUILD_CFLAGS="$INCLUDES -DHAVE_CONFIG_H"

I would think that

BUILD_CFLAGS="-I$(top_builddir)/lib -DHAVE_CONFIG_H"

... would be safer, since $INCLUDES could potentially include some
$CPPFLAGS that could be specific to the target architecture.

Yes?

- Ted