Re: [PATCH] e2fsprogs: Add INCLUDES to BUILD_CFLAGS when cross-compiling

Gustavo Zacarias
2014-07-06T00:32:55Z

On 07/05/2014 08:55 PM, Theodore Ts'o wrote:

> I would think that
>
> BUILD_CFLAGS="-I$(top_builddir)/lib -DHAVE_CONFIG_H"
>
> ... would be safer, since $INCLUDES could potentially include some
> $CPPFLAGS that could be specific to the target architecture.
>
> Yes?

Not really, since that way it's missing config.h, still failing:

-----
cd ./util ; /usr/bin/make subst
make[2]: Entering directory
`/home/gustavoz/b/test/output/build/e2fsprogs-1.42.10/util'
CREATE dirpaths.h
CC subst.c
subst.c:8:20: fatal error: config.h: No such file or directory
compilation terminated.
-----

Regards.