From: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: <linux-ext4@vger.kernel.org>, <adilger@dilger.ca>, <lczerner@redhat.com>
Subject: Re: [PATCH] ext4: save goal group and offset in struct ext4_allocation_context.ac_g_ex
Date: Fri, 1 Aug 2014 09:13:49 +0800 [thread overview]
Message-ID: <53DAE9CD.5090308@cn.fujitsu.com> (raw)
In-Reply-To: <20140731153255.GE1566@thunk.org>
Hi Ted,
On 07/31/2014 11:32 PM, Theodore Ts'o wrote:
> On Tue, Jul 29, 2014 at 09:58:19AM -0400, Theodore Ts'o wrote:
>> On Wed, Jul 23, 2014 at 05:47:41PM +0800, Xiaoguang Wang wrote:
>>> In ext4_mb_normalize_request(), if ac_g_ex.fe_logical is adjacent to the closest logical
>>> allocated block to the left or (ac_g_ex.fe_logical+len) adjacent to the closest logical
>>> allocated block to the right, we'll attach EXT4_MB_HINT_TRY_GOAL flag taking the physical
>>> block (ext4_allocation_request.lleft+1) or (ext4_allocation_request.pright-len) as a goal,
>>> and put this information in ext4_allocation_context.ac_f_ex.
>>>
>>> But look at the ext4_mb_find_by_goal(), indeed it use ac_g_ex to look up, so this is wrong,
>>> we should save goal group and offset in struct ext4_allocation_context.ac_g_ex.
>>>
>>> Signed-off-by: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
>>
>> Nice catch!
>>
>> Thanks, applied.
>
> I've had to drop this patch, as it is causing xfstests failures for
> generic/074.
Before sending this patch, I didn't run the whole xfstests for ext4, sorry.
Next time, if I'll send some new patches, I'll run the xfstests for ext4.
>
> I'm not sure why, and right now I don't have time to investigate. If
> someone who has time and experience wading into fs/ext4/mballoc.c, it
> would be great if someone could take a closer look.
I'll investigate it and have full tests, thanks!
Regards,
Xiaoguang Wang
>
> - Ted
> .
>
next prev parent reply other threads:[~2014-08-01 1:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 9:47 [PATCH] ext4: save goal group and offset in struct ext4_allocation_context.ac_g_ex Xiaoguang Wang
2014-07-29 13:58 ` Theodore Ts'o
2014-07-31 15:32 ` Theodore Ts'o
2014-08-01 1:13 ` Xiaoguang Wang [this message]
2014-08-01 12:40 ` Theodore Ts'o
2014-08-04 7:00 ` Xiaoguang Wang
2014-08-04 10:39 ` [PATCH v2] " Xiaoguang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DAE9CD.5090308@cn.fujitsu.com \
--to=wangxg.fnst@cn.fujitsu.com \
--cc=adilger@dilger.ca \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).