linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Hunt <johunt@akamai.com>
To: Jan Kara <jack@suse.cz>
Cc: "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
	"tytso@mit.edu" <tytso@mit.edu>,
	"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>
Subject: Re: ext4_da_update_reserve_space warning fix not in stable
Date: Wed, 7 Jan 2015 13:49:46 -0600	[thread overview]
Message-ID: <54AD8DDA.6090902@akamai.com> (raw)
In-Reply-To: <20150107192105.GE2802@quack.suse.cz>

On 01/07/2015 01:21 PM, Jan Kara wrote:
> On Wed 07-01-15 12:12:59, Josh Hunt wrote:
>> We are hitting the following warning in the field pretty frequently
>> on the latest 3.10 stable kernel:
>> [11708.763067] WARNING: at fs/ext4/inode.c:363
>> ext4_da_update_reserve_space+0x261/0x280 [ext4]()
>>
>> The issue was resolved via "ext4: fix warning in
>> ext4_da_update_reserve_space()" (7d7345322d60ed), but the fix was
>> not submitted as a stable update for 3.10. I was wondering if
>> there's a reason why this was not done, or if it was just
>> overlooked?
>>
>> The patch appears to have a dependency on "quota: provide interface
>> for readding allocated space into reserved space" (1c8924eb106c1ac),
>> so I think both would need to be submitted if you feel it's
>> possible.
>    Since the problem is relatively harmless, I think we didn't bother
> porting it to 3.10. Feel free to port those two patches to 3.10 and submit
> them to stable@vger.kernel.org.

Thanks for the reply Jan.

I've ported them locally to 3.10 and they seem to apply cleanly as-is. I 
can submit the request to stable as long as you believe there's no harm 
in doing so, or any other dependency which may be required. My testing 
of a patched 3.10 with the two above patches shows the warning no longer 
triggers as you report in your commit log.

Thanks
Josh

  reply	other threads:[~2015-01-07 19:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07 18:12 ext4_da_update_reserve_space warning fix not in stable Josh Hunt
2015-01-07 19:21 ` Jan Kara
2015-01-07 19:49   ` Josh Hunt [this message]
2015-01-08  7:48     ` Jan Kara
2015-01-08 17:58       ` Josh Hunt
2015-01-07 19:53 ` Theodore Ts'o
2015-01-07 20:16   ` Josh Hunt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AD8DDA.6090902@akamai.com \
    --to=johunt@akamai.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).