public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Bernd Schubert <bernd.schubert@fastmail.fm>
To: Olaf Hering <olaf@aepfle.de>, linux-ext4@vger.kernel.org
Cc: Jan Kara <jack@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andreas Dilger <adilger.kernel@dilger.ca>
Subject: Re: [PATCH] ext3: dump dentry in ext3_dx_add_entry
Date: Tue, 03 Feb 2015 11:39:36 +0100	[thread overview]
Message-ID: <54D0A568.4050905@fastmail.fm> (raw)
In-Reply-To: <1422955349-19631-1-git-send-email-olaf@aepfle.de>



On 02/03/2015 10:22 AM, Olaf Hering wrote:
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> ---
>  fs/ext3/namei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c
> index f197736..0692058 100644
> --- a/fs/ext3/namei.c
> +++ b/fs/ext3/namei.c
> @@ -1529,7 +1529,7 @@ static int ext3_dx_add_entry(handle_t *handle, struct dentry *dentry,
>  		if (levels && (dx_get_count(frames->entries) ==
>  			       dx_get_limit(frames->entries))) {
>  			ext3_warning(sb, __func__,
> -				     "Directory index full!");
> +				     "Directory index full! %pd4 %pd", dentry->d_parent, dentry);
>  			err = -ENOSPC;
>  			goto cleanup;
>  		}

Would you mind to also add the inode number? That way one could use
debugfs to figure out the complete path.
And it should be done for ext4 as well.



Cheers,
Bernd

      reply	other threads:[~2015-02-03 10:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-03  9:22 [PATCH] ext3: dump dentry in ext3_dx_add_entry Olaf Hering
2015-02-03 10:39 ` Bernd Schubert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D0A568.4050905@fastmail.fm \
    --to=bernd.schubert@fastmail.fm \
    --cc=adilger.kernel@dilger.ca \
    --cc=akpm@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=olaf@aepfle.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox