From: Eric Sandeen <sandeen@redhat.com>
To: Enrico Mioso <mrkiko.rs@gmail.com>, linux-kernel@vger.kernel.org
Cc: linux-ext4@vger.kernel.org
Subject: Re: Bug in mount options handling in EXT4?
Date: Wed, 04 Feb 2015 21:57:24 -0600 [thread overview]
Message-ID: <54D2EA24.70206@redhat.com> (raw)
In-Reply-To: <alpine.LNX.2.03.1502050418390.11412@gmail.com>
On 2/4/15 9:22 PM, Enrico Mioso wrote:
> Hello guys.
> I noticed from some time, that I can make mount options accumulate simply continously repeating them.
> By typing:
> sudo mount -t ext4 -o rw,noatime,nobarrier,nobarrier,nobarrier, ...
> I can get:
> $ dmesg | tail
> [ 216.075581] EXT4-fs (sdb): mounted filesystem without journal. Opts: nobarrier
> [ 472.851105] snd_hda_intel 0000:00:1b.0: IRQ timing workaround is activated for card #0. Suggest a bigger bdl_pos_adj.
> [41950.250515] EXT4-fs (sdc1): re-mounted. Opts: nobarrier,nobarrier
> [42093.049879] EXT4-fs (sdc1): re-mounted. Opts: nobarrier,nobarrier
> [42095.673967] EXT4-fs (sdc1): re-mounted. Opts: nobarrier,nobarrier
> [42095.954595] EXT4-fs (sdc1): re-mounted. Opts: nobarrier,nobarrier
> [42096.220220] EXT4-fs (sdc1): re-mounted. Opts: nobarrier,nobarrier
> [42103.212371] EXT4-fs (sdc1): re-mounted. Opts: nobarrier,nobarrier,nobarrier
> [42128.137609] EXT4-fs (sdc1): re-mounted. Opts: nobarrier,nobarrier,nobarrier,nobarrier,nobarrier,nobarrier,nobarrier
> [42144.960612] EXT4-fs (sdc1): re-mounted. Opts: nobarrier,nobarrier,nobarrier,nobarrier,nobarrier,nobarrier,nobarrier,nobarrier,nobarrier,nobarrier,nobarrier,nobarrier,nobarrier
Hm, yes, it's really only cosmetic in that printk.
> But the problem seems limited to the filesystem messages / something like that:
> $ cat /proc/mounts
...
> /dev/sdc1 /mnt/trekstor ext4 rw,noatime,nobarrier 0 0
Yep, because when this is printed, it simply looks at the set option flags,
and essentially prints the option name once for each (non-default) flag
that is set.
What we probably would want is something similar to that code (in
_ext4_show_options) which is more generic, and could generate a string
for use in the remount case as well.
-Eric
next prev parent reply other threads:[~2015-02-05 3:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 3:22 Bug in mount options handling in EXT4? Enrico Mioso
2015-02-05 3:57 ` Eric Sandeen [this message]
2015-02-05 4:26 ` Enrico Mioso
2015-02-05 4:52 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D2EA24.70206@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mrkiko.rs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).