From: Joseph Qi <joseph.qi@huawei.com>
To: <linux-ext4@vger.kernel.org>
Subject: Issue in ext4 rename
Date: Thu, 2 Apr 2015 18:49:07 +0800 [thread overview]
Message-ID: <551D1EA3.1050202@huawei.com> (raw)
Hi all,
In ext4_rename_delete, it only logs a warning if ext4_delete_entry
fails.
IMO, it may lead to an inode with two entries (old and new), thus
filesystem will be inconsistent.
The case is described below:
ext4_rename
--> ext4_journal_start
--> ext4_add_entry (new)
--> ext4_rename_delete (old)
--> ext4_delete_entry
--> ext4_journal_get_write_access
*failed* because of -ENOMEM
--> ext4_journal_stop
Does anyone have an idea to resolve this issue?
next reply other threads:[~2015-04-02 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 10:49 Joseph Qi [this message]
2015-04-02 14:02 ` Issue in ext4 rename Theodore Ts'o
2015-04-03 9:57 ` Joseph Qi
2015-04-03 15:06 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551D1EA3.1050202@huawei.com \
--to=joseph.qi@huawei.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).