linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] e2fsprogs: use $DUMPE2FS in resize_test script
@ 2015-04-20 17:59 Eric Sandeen
  2015-05-23 22:40 ` Theodore Ts'o
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2015-04-20 17:59 UTC (permalink / raw)
  To: ext4 development

Use $DUMPE2FS in resize tests to be sure it's testing
the in-tree dumpe2fs, not the system dumpe2fs (which may
not even be there...)

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

(somehow I thought I had sent this, or something similar, before ...
can't find it, oh well!)

diff --git a/tests/scripts/resize_test b/tests/scripts/resize_test
index 0633e0c..dfd45ac 100755
--- a/tests/scripts/resize_test
+++ b/tests/scripts/resize_test
@@ -67,7 +67,7 @@ fi
 echo $FSCK -fy $TMPFILE >> $LOG 2>&1
 if ! $FSCK -fy $TMPFILE >> $LOG 2>&1
 then
-	dumpe2fs $TMPFILE >> $LOG
+	$DUMPE2FS $TMPFILE >> $LOG
 	return 1
 fi
 
@@ -97,7 +97,7 @@ fi
 echo $FSCK -fy $TMPFILE >> $LOG 2>&1
 if ! $FSCK -fy $TMPFILE >> $LOG 2>&1
 then
-	dumpe2fs $TMPFILE >> $LOG
+	$DUMPE2FS $TMPFILE >> $LOG
 	return 1
 fi
 
@@ -122,7 +122,7 @@ fi
 echo $FSCK -fy $TMPFILE >> $LOG 2>&1
 if ! $FSCK -fy $TMPFILE >> $LOG 2>&1
 then
-	dumpe2fs $TMPFILE >> $LOG
+	$DUMPE2FS $TMPFILE >> $LOG
 	return 1
 fi
 
@@ -147,7 +147,7 @@ fi
 echo $FSCK -fy $TMPFILE >> $LOG 2>&1
 if ! $FSCK -fy $TMPFILE >> $LOG 2>&1
 then
-	dumpe2fs $TMPFILE >> $LOG
+	$DUMPE2FS $TMPFILE >> $LOG
 	return 1
 fi
 


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] e2fsprogs: use $DUMPE2FS in resize_test script
  2015-04-20 17:59 [PATCH] e2fsprogs: use $DUMPE2FS in resize_test script Eric Sandeen
@ 2015-05-23 22:40 ` Theodore Ts'o
  0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2015-05-23 22:40 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: ext4 development

On Mon, Apr 20, 2015 at 12:59:11PM -0500, Eric Sandeen wrote:
> Use $DUMPE2FS in resize tests to be sure it's testing
> the in-tree dumpe2fs, not the system dumpe2fs (which may
> not even be there...)
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Applied, thanks

					- Ted

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-05-23 22:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-20 17:59 [PATCH] e2fsprogs: use $DUMPE2FS in resize_test script Eric Sandeen
2015-05-23 22:40 ` Theodore Ts'o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).