Re: [PATCH v8 00/41] Richacls

[Austin S Hemmelgarn <ahferroin7@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2299 bytes --]

On 2015-10-05 14:45, Andreas Gruenbacher wrote:
> On Sun, Oct 4, 2015 at 8:23 AM, Christoph Hellwig <hch@infradead.org> wrote:
>> On Mon, Sep 28, 2015 at 12:08:51AM +0200, Andreas Gruenbacher wrote:
>>> Hello,
>>>
>>> here's another update of the richacl patch queue.  At this stage, I would
>>> like to ask for final feedback so that the core and ext4 code (patches
>>> 1-19) can be merged in the 4.4 merge window.  The nfsd and nfs code should
>>> then go through the respective maintainer trees.
>>
>> Now way in this form even if everyone agrees we should have these
>> bastard ACLs.  I certainly disagree.
>
> Well, thanks for having a look at the patches.
>
>> Ayway, back to the VFS <-> FS interface.  You still require tons of
>> boilderplate code in the filesystem which isn't required and we got rid
>> of for Posix ACLs.  The filesystem should not look at the userspace
>> xattr format, please follow a model similar to ->get_acl and ->set_acl
>> for Posix ACLs.
>
> I will repost a version that has this cleaned up.
>
>> After that the wire up should be so trivial that you can wire up btrfs,
>> xfs and f2fs as well, which is important to make the feature mergeable.
>
> Why would the patch queue become more mergeable by having support for
> more filesystems in it? The filesystem specific code really isn't all
> that interesting.
I think the point is that a new VFS feature that is easy to integrate in 
multiple filesystems should have support for those filesystems.  A 
decade ago, just having ext* support would probably have been fine, but 
these days, XFS, BTRFS, and F2FS are used just as much (if not more) on 
production systems as ext4, and having support for them right from the 
start would significantly help with adoption of richacls.
>
>> And honestly I tink adding even more overload to xattrs is a really bad
>> idea and after 10 years of experience with that junk we really need to
>> learn and make new overloads proper system calls.
>
> Thanks,
> Andreas
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 3019 bytes --]