From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH v2 02/11] mm: add pmd_mkclean()
Date: Fri, 13 Nov 2015 17:02:48 -0800
Message-ID: <56468838.6010506@intel.com>
References: <1447459610-14259-1-git-send-email-ross.zwisler@linux.intel.com>
 <1447459610-14259-3-git-send-email-ross.zwisler@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: "H. Peter Anvin" <hpa@zytor.com>, "J. Bruce Fields"
 <bfields@fieldses.org>, Theodore Ts'o <tytso@mit.edu>,
 Alexander Viro <viro@zeniv.linux.org.uk>,
 Andreas Dilger <adilger.kernel@dilger.ca>,
 Dan Williams <dan.j.williams@intel.com>, Dave Chinner <david@fromorbit.com>,
 Ingo Molnar <mingo@redhat.com>, Jan Kara <jack@suse.com>,
 Jeff Layton <jlayton@poochiereds.net>, Matthew Wilcox
 <willy@linux.intel.com>, Thomas Gleixner <tglx@linutronix.de>,
 linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
 linux-mm@kvack.org, linux-nvdimm@lists.01.org, x86@kernel.org,
 xfs@oss.sgi.com, Andrew Morton <akpm@linux-foundation.org>,
 Matthew Wilcox <matthew.r.wilcox@intel.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>, linux-kernel@vger.kernel.org
Return-path: <owner-linux-mm@kvack.org>
In-Reply-To: <1447459610-14259-3-git-send-email-ross.zwisler@linux.intel.com>
Sender: owner-linux-mm@kvack.org
List-Id: linux-ext4.vger.kernel.org

On 11/13/2015 04:06 PM, Ross Zwisler wrote:
> +static inline pmd_t pmd_mkclean(pmd_t pmd)
> +{
> +	return pmd_clear_flags(pmd, _PAGE_DIRTY | _PAGE_SOFT_DIRTY);
> +}

pte_mkclean() doesn't clear _PAGE_SOFT_DIRTY.  What the thought behind
doing it here?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>