From: Eric Sandeen <sandeen@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH V2] resize2fs: clear uninit BG if allocating from new group
Date: Thu, 14 Jan 2016 13:26:22 -0600 [thread overview]
Message-ID: <5697F65E.20201@redhat.com> (raw)
In-Reply-To: <20160114185043.GA5749@birch.djwong.org>
On 1/14/16 12:50 PM, Darrick J. Wong wrote:
> On Thu, Jan 14, 2016 at 12:46:03PM -0600, Eric Sandeen wrote:
...
>> diff --git a/lib/ext2fs/ext2fs.h b/lib/ext2fs/ext2fs.h
>> index 86d860f..0dca002 100644
>> --- a/lib/ext2fs/ext2fs.h
>> +++ b/lib/ext2fs/ext2fs.h
>> @@ -647,6 +647,7 @@ static inline int ext2fs_needs_large_file_feature(unsigned long long file_size)
>> }
>>
>> /* alloc.c */
>> +extern void clear_block_uninit(ext2_filsys fs, dgrp_t group);
>
> If you're going to expose this as a new API call then this needs to be
> ext2fs_clear_block_uninit().
Hm, yes. I tried to work around it but don't see a nice way.
> (Do we want a flags arg just in case we ever need one?)
No. ;)
(EXT2_CLEAR_GROUP_UNINIT_HALFWAY? I can't really think of any reasonable
variation on "clear this group's uninit status")
-Eric
next prev parent reply other threads:[~2016-01-14 19:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 22:42 [PATCH] resize2fs: clear uninit BG if allocating from new group Eric Sandeen
2015-09-17 23:55 ` Darrick J. Wong
2015-09-18 0:54 ` Eric Sandeen
2015-09-18 3:19 ` Eric Sandeen
2016-01-14 14:09 ` Eric Sandeen
2016-01-14 17:20 ` Andreas Dilger
2016-01-14 18:46 ` [PATCH V2] " Eric Sandeen
2016-01-14 18:50 ` Darrick J. Wong
2016-01-14 19:26 ` Eric Sandeen [this message]
2016-01-14 19:27 ` [PATCH V3] " Eric Sandeen
2016-01-14 19:38 ` Darrick J. Wong
2016-01-14 19:39 ` Andreas Dilger
2016-01-14 19:57 ` Eric Sandeen
2016-02-19 22:21 ` Eric Sandeen
2016-03-07 2:51 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5697F65E.20201@redhat.com \
--to=sandeen@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).