From: Eric Sandeen <sandeen@sandeen.net>
To: xfs@oss.sgi.com
Cc: "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] xfs_quota: allow operation on foreign filesystem types
Date: Fri, 15 Jan 2016 22:41:15 -0600 [thread overview]
Message-ID: <5699C9EB.10307@sandeen.net> (raw)
In-Reply-To: <1452729788-5396-1-git-send-email-david@fromorbit.com>
On 1/13/16 6:03 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> This allows xfs_quota to be used on ext4 for project quota testing
> in xfstests.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
...
> diff --git a/quota/report.c b/quota/report.c
> index c77b24f..eaf3a67 100644
> --- a/quota/report.c
> +++ b/quota/report.c
> @@ -658,6 +658,7 @@ report_init(void)
> dump_cmd.args = _("[-gpu] [-f file]");
> dump_cmd.oneline = _("dump quota information for backup utilities");
> dump_cmd.help = dump_help;
> + dump_cmd.flags = CMD_FLAG_FOREIGN_OK;
>
> report_cmd.name = "report";
> report_cmd.altname = "repquota";
> @@ -668,6 +669,7 @@ report_init(void)
> report_cmd.args = _("[-bir] [-gpu] [-ahnt] [-f file]");
> report_cmd.oneline = _("report filesystem quota information");
> report_cmd.help = report_help;
> + report_cmd.flags = CMD_FLAG_FOREIGN_OK;
There's another
report_cmd.flags = CMD_FLAG_GLOBAL;
above this which gets overwritten here; this command needs to be:
report_cmd.flags = CMD_FLAG_GLOBAL | CMD_FLAG_FOREIGN_OK;
or else
xfs_quota -x -c "report -a"
goes bonkers, iterating in nested loops and printing filesystems multiple times.
It also seems that "report -a" should not be changing defaults this way such
that non-xfs filesystems will get printed; this will be an unexpected change
to default behavior.
Perhaps a top-level "-f" option to explicitly enable foreign filesystem detection
would be best?
-Eric
prev parent reply other threads:[~2016-01-16 4:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 0:03 [PATCH] xfs_quota: allow operation on foreign filesystem types Dave Chinner
2016-01-16 4:41 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5699C9EB.10307@sandeen.net \
--to=sandeen@sandeen.net \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).