From: Georg Altmann <george@george-net.de>
To: unlisted-recipients:; (no To-header on input)
Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: clarify error messages for mounting fs w/o journal /w journal options
Date: Fri, 12 Feb 2016 18:32:47 +0100 [thread overview]
Message-ID: <56BE173F.2050703@george-net.de> (raw)
In-Reply-To: <20160212170308.GC7928@thunk.org>
[-- Attachment #1: Type: text/plain, Size: 2135 bytes --]
Am 12.02.2016 um 18:03 schrieb Theodore Ts'o:
> On Fri, Feb 12, 2016 at 02:31:49PM +0100, Georg Altmann wrote:
>> Previous message was hard to understand: When mounting a ext4 fs without a
>> journal, but a mount option that controls journaling is used, clearly state
>> that the fs cannot be mounted with this option because it has no journal.
>
> Well, technically it's possible for the file system to have a journal,
> but for journalling not to be enabled. For example:
>
> root@kvm-xfstests:~# dmesg -n 7
> root@kvm-xfstests:~# mke2fs -t ext4 -Fq /dev/vdc
> /dev/vdc contains a ext4 file system
> created on Fri Feb 12 11:59:10 2016
> root@kvm-xfstests:~# dumpe2fs /dev/vdc | grep features
> dumpe2fs 1.43-WIP (18-May-2015)
> Filesystem features: has_journal ext_attr resize_inode dir_index filetype extent 64bit flex_bg sparse_super large_file huge_file dir_nlink extra_isize metadata_csum
> Journal features: (none)
> root@kvm-xfstests:~# mount -o noload,commit=1 /dev/vdc /vdc 2> /dev/null
> [ 313.867505] EXT4-fs (vdc): can't mount with commit=1, fs mounted w/o journal
>
> So saying "fs has no journal" isn't necessarily going to be correct.
> Maybe "Can't mount with data=xxx, journalling not enabled" would be
> less confusing to users?
Yes.
I do not understand the error checking logic here enough:
it could be either fs without journal or journal not enabled, right?
So how about
"can't mount with data=xxx, journalling not enabled or no journal"
?
Or, if this can be justified in regard of code complexity, handle both
cases separately. Even nicer diagnostics for the user...
Should I send a new patch?
Regards,
Georg
--
PGP-Key: 0x1E320E65
D150 7783 A0D1 7507 1266 C5B3 BBF1 9C42 1E32 0E65
I don't like the idea of secret agencies to analyse and archive
personal communication. GnuPG is available as open source, free as as in
freedom, as a countermeasure. I use http://www.enigmail.net/ for Mozilla
Thunderbird. If you can, please use a frontend of your choice to send me
encrypted e-mail. See http://www.gnupg.org/ for an overview.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-02-12 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 13:31 [PATCH] ext4: clarify error messages for mounting fs w/o journal /w journal options Georg Altmann
2016-02-12 17:03 ` Theodore Ts'o
2016-02-12 17:32 ` Georg Altmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BE173F.2050703@george-net.de \
--to=george@george-net.de \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).