public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Wu Guanghao <wuguanghao3@huawei.com>
To: <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org,
	"Благодаренко Артём" <artem.blagodarenko@gmail.com>,
	liuzhiqiang26@huawei.com, linfeilong@huawei.com
Subject: Re: [PATCH V2 00/12] e2fsprogs: some bugfixs and some code cleanups
Date: Mon, 31 May 2021 16:28:19 +0800	[thread overview]
Message-ID: <57045838-ae1a-d1d9-23ef-8977a4accc17@huawei.com> (raw)
In-Reply-To: <e4df8d8a-a5b2-a3cf-7e0d-c5dceb3b39f9@huawei.com>

Hello Ted,

Thank you for your advice, I will pay attention to it in the future.
Do I need to resend the series of patches
or continue to send the remaining patches this time?

Thanks,
Wu Guanghao

On Mon, 31 May 2021 00:28:46 -0400, Theodore Ts'o wrote:
> 
> 
> 
> On Mon, May 31, 2021 at 09:23:49AM +0800, Wu Guanghao wrote:
>> V1 -> V2:
>>
>> [PATCH V2 03/12] zap_sector: fix memory leak
>>     free and return operators placed in {} block
>>
>> [PATCH V2 04/12] ss_add_info_dir: fix memory leak and check whether,NULL pointer
>>     modified "=" to "=="
>>
>> [PATCH V2 06/12] append_pathname: check the value returned by realloc to avoid segfault
>> [PATCH V2 07/12] argv_parse: check return value of malloc in argv_parse()
>>     Fix typos
>>
>> [PATCH V2 10/12] hashmap: change return value type of, ext2fs_hashmap_add()
>>     remove "new_block = NULL;"
> 
> Did you only send the patches that you changed, and didn't resend the
> patches that didn't change between V1 and V2?
> 
> It's actually better if you resend the whole series in the future.
> 
> Thanks,
> 
>                     - Ted
> .
> .

  parent reply	other threads:[~2021-05-31  8:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-31  1:23 [PATCH V2 00/12] e2fsprogs: some bugfixs and some code cleanups Wu Guanghao
2021-05-31  1:26 ` [PATCH V2 03/12] zap_sector: fix memory leak Wu Guanghao
2021-05-31  1:28 ` [PATCH V2 04/12] ss_add_info_dir: fix memory leak and check whether,NULL pointer Wu Guanghao
2021-05-31  1:30 ` [PATCH V2 06/12] append_pathname: check the value returned by realloc to avoid segfault Wu Guanghao
2021-05-31  1:31 ` [PATCH V2 07/12] argv_parse: check return value of malloc in argv_parse() Wu Guanghao
2021-05-31  1:32 ` [PATCH V2 10/12] hashmap: change return value type of, ext2fs_hashmap_add() Wu Guanghao
2021-05-31  4:28 ` [PATCH V2 00/12] e2fsprogs: some bugfixs and some code cleanups Theodore Ts'o
     [not found]   ` <e4df8d8a-a5b2-a3cf-7e0d-c5dceb3b39f9@huawei.com>
2021-05-31  8:28     ` Wu Guanghao [this message]
2021-06-15 11:27   ` Zhiqiang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57045838-ae1a-d1d9-23ef-8977a4accc17@huawei.com \
    --to=wuguanghao3@huawei.com \
    --cc=artem.blagodarenko@gmail.com \
    --cc=linfeilong@huawei.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=liuzhiqiang26@huawei.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox