From: Daniel Dawson <danielcdawson@gmail.com>
To: Luis Henriques <lhenriques@suse.de>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] ext4: destroy inline data immediately when converting to extent
Date: Thu, 8 Feb 2024 17:31:00 -0800 [thread overview]
Message-ID: <58418b66-8dd1-41ca-90d6-f1dc3176c9be@gmail.com> (raw)
In-Reply-To: <20240208165808.5494-1-lhenriques@suse.de>
On 2/8/24 8:58 AM, Luis Henriques wrote:
> The 'lsattr' command shows that the file has data stored inline. However,
> that is not correct because writing 192 bytes (3 * 64) has forced the data
> to be un-inlined. Doing a 'sync' before running the 'lsattr' fixes it.
I know I'm the one who initially reported this, but I suppose there is
an argument to be made that this in itself is not a bug, as Ted seemed
to say before. What is a problem, however, is lseek() giving ENOENT when
the kernel finds file data where it expects to find a block/extent map,
and I can confirm this patch solves that (tested against 6.8.0-rc3). Not
sure if it's the best thing to do so by forcing immediate allocation,
but I feel it's still an improvement.
--
PGP fingerprint: 5BBD5080FEB0EF7F142F8173D572B791F7B4422A
prev parent reply other threads:[~2024-02-09 1:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 16:58 [RFC PATCH] ext4: destroy inline data immediately when converting to extent Luis Henriques
2024-02-09 1:31 ` Daniel Dawson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58418b66-8dd1-41ca-90d6-f1dc3176c9be@gmail.com \
--to=danielcdawson@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=lhenriques@suse.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox