From: David Laight <David.Laight@ACULAB.COM>
To: 'Jan Kara' <jack@suse.cz>, Amir Goldstein <amir73il@gmail.com>
Cc: Ted Tso <tytso@mit.edu>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] ext4: Fix possible corruption when moving a directory with RENAME_EXCHANGE
Date: Wed, 24 May 2023 14:25:11 +0000 [thread overview]
Message-ID: <58ea6b856874446c85c6c302016f9a61@AcuMS.aculab.com> (raw)
In-Reply-To: <20230524141852.gu75mudt4snub4ed@quack3>
From: Jan Kara
> Sent: 24 May 2023 15:19
....
> Right, so this case indeed looks possible and I didn't think about it.
> Thanks for spotting this! Let me try to persuade Al again to do the
> necessary locking in VFS as it is getting really hairy and needs VFS
> changes anyway.
I think it was NetBSD that started using a global lock for
non-trival renames because otherwise it is all 'just too hard'.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
prev parent reply other threads:[~2023-05-24 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 13:14 [PATCH] ext4: Fix possible corruption when moving a directory with RENAME_EXCHANGE Jan Kara
2023-05-23 13:50 ` David Laight
2023-05-24 10:51 ` Jan Kara
2023-05-24 13:11 ` Amir Goldstein
2023-05-24 14:18 ` Jan Kara
2023-05-24 14:25 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58ea6b856874446c85c6c302016f9a61@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=amir73il@gmail.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox