linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Damien Guibouret <damien.guibouret@partition-saving.com>
To: linux-ext4@vger.kernel.org
Subject: Remove useless test and initialisation in name to hash computation
Date: Tue, 25 Jul 2017 20:40:03 +0200	[thread overview]
Message-ID: <59779083.7000501@partition-saving.com> (raw)

Hello,

I think there is a minor improvment that could be performed on name to hash 
computation in hash.c. Before first byte modulo 4 the computed value is 
reinitialised, but it is already correctly initialised before loop and after 
having processed last byte modulo 4. So the test and initialisation seems useless.

For the kernel, this lead to following change (sorry I do not have a git version 
of it, so it is a simple diff):
---------------------------------------------------------------
--- fs/ext4/hash.c.orig 2017-07-24 20:41:53.000000000 +0200
+++ fs/ext4/hash.c      2017-07-24 20:42:23.000000000 +0200
@@ -79,8 +79,6 @@ static void str2hashbuf_signed(const cha
         if (len > num*4)
                 len = num * 4;
         for (i = 0; i < len; i++) {
-               if ((i % 4) == 0)
-                       val = pad;
                 val = ((int) scp[i]) + (val << 8);
                 if ((i % 4) == 3) {
                         *buf++ = val;
@@ -107,8 +105,6 @@ static void str2hashbuf_unsigned(const c
         if (len > num*4)
                 len = num * 4;
         for (i = 0; i < len; i++) {
-               if ((i % 4) == 0)
-                       val = pad;
                 val = ((int) ucp[i]) + (val << 8);
                 if ((i % 4) == 3) {
                         *buf++ = val;
---------------------------------------------------------------

For e2fsprogs, the 2 functions are combined in one, so there is only one change:
---------------------------------------------------------------
diff --git a/lib/ext2fs/dirhash.c b/lib/ext2fs/dirhash.c
index c4ac94e..4ba3f35 100644
--- a/lib/ext2fs/dirhash.c
+++ b/lib/ext2fs/dirhash.c
@@ -154,8 +154,6 @@ static void str2hashbuf(const char *msg, int len, __u32 
*buf, int num,
      if (len > num*4)
          len = num * 4;
      for (i=0; i < len; i++) {
-        if ((i % 4) == 0)
-            val = pad;
          if (unsigned_flag)
              c = (int) ucp[i];
          else
---------------------------------------------------------------

Regards,

Damien

             reply	other threads:[~2017-07-25 18:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25 18:40 Damien Guibouret [this message]
2017-07-26 11:42 ` Remove useless test and initialisation in name to hash computation Lukas Czerner
2017-07-26 19:56   ` Damien Guibouret

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59779083.7000501@partition-saving.com \
    --to=damien.guibouret@partition-saving.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).