linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: piaojun <piaojun@huawei.com>
To: Jan Kara <jack@suse.cz>
Cc: <adilger.kernel@dilger.ca>, <arnd@arndb.de>,
	<linux-ext4@vger.kernel.org>
Subject: [PATCH] ext4: no need flush workqueue before destroying it
Date: Tue, 9 Jan 2018 20:37:54 +0800	[thread overview]
Message-ID: <5A54B7A2.8050101@huawei.com> (raw)

destroy_workqueue() will do flushing work for us.

Signed-off-by: Jun Piao <piaojun@huawei.com>
---
 fs/ext4/super.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 0556cd0..2f46b0b 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -870,7 +870,6 @@ static void ext4_put_super(struct super_block *sb)
 	ext4_unregister_li_request(sb);
 	ext4_quota_off_umount(sb);

-	flush_workqueue(sbi->rsv_conversion_wq);
 	destroy_workqueue(sbi->rsv_conversion_wq);

 	if (sbi->s_journal) {
-- 

             reply	other threads:[~2018-01-09 12:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09 12:37 piaojun [this message]
2018-01-09 15:07 ` [PATCH] ext4: no need flush workqueue before destroying it Jan Kara
2018-01-10  0:16   ` piaojun
2018-01-10  2:42     ` Theodore Ts'o
  -- strict thread matches above, loose matches on Subject: below --
2018-01-10  0:19 piaojun
2017-12-01  7:44 piaojun
2017-12-04  0:43 ` piaojun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A54B7A2.8050101@huawei.com \
    --to=piaojun@huawei.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=arnd@arndb.de \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).