From: Andreas Dilger <adilger@dilger.ca>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: linux-ext4@vger.kernel.org, sandeen@redhat.com
Subject: Re: [PATCH] ext4:Make FIEMAP and delayed allocation play well together.
Date: Sat, 26 Feb 2011 23:57:55 -0700 [thread overview]
Message-ID: <5B306456-0ECB-481A-9AA5-FD04FC71C216@dilger.ca> (raw)
In-Reply-To: <1298732709-3212-1-git-send-email-xiaoqiangnk@gmail.com>
On 2011-02-26, at 8:05 AM, Yongqiang Yang wrote:
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
You can also add Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> @@ -3782,38 +3783,162 @@ static int ext4_ext_fiemap_cb(struct inode *inode, struct ext4_ext_path *path,
> struct ext4_ext_cache *newex, struct ext4_extent *ex,
> void *data)
> {
> if (newex->ec_start == 0) {
> + pages = kmalloc(PAGE_SIZE, GFP_KERNEL);
> + if (pages == NULL)
> + return -EFAULT;
This should be -ENOMEM.
Cheers, Andreas
next prev parent reply other threads:[~2011-02-27 6:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 15:05 [PATCH] ext4:Make FIEMAP and delayed allocation play well together Yongqiang Yang
2011-02-26 15:04 ` Yongqiang Yang
2011-02-27 6:57 ` Andreas Dilger [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-02-27 6:38 Yongqiang Yang
2011-02-27 6:37 ` Yongqiang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B306456-0ECB-481A-9AA5-FD04FC71C216@dilger.ca \
--to=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox