From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71FB9C433F5 for ; Sat, 4 Sep 2021 03:21:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BCF461054 for ; Sat, 4 Sep 2021 03:21:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236207AbhIDDWX (ORCPT ); Fri, 3 Sep 2021 23:22:23 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:15286 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231243AbhIDDWV (ORCPT ); Fri, 3 Sep 2021 23:22:21 -0400 Received: from dggeme752-chm.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4H1g0j3hY2z8snZ; Sat, 4 Sep 2021 11:20:53 +0800 (CST) Received: from [10.174.178.134] (10.174.178.134) by dggeme752-chm.china.huawei.com (10.3.19.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.8; Sat, 4 Sep 2021 11:21:18 +0800 Subject: Re: [PATCH v3 0/4] ext4: improve delalloc buffer write performance To: CC: , , , References: <20210716122024.1105856-1-yi.zhang@huawei.com> From: Zhang Yi Message-ID: <5d0c1cf0-c430-6c15-7cce-dc16bf9d7cf7@huawei.com> Date: Sat, 4 Sep 2021 11:21:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20210716122024.1105856-1-yi.zhang@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.134] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggeme752-chm.china.huawei.com (10.3.19.98) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hi, Ted Do you plan to merge this speed up patch set for 5.15? Thanks, Yi. On 2021/7/16 20:20, Zhang Yi wrote: > Hi, > > Changes since v2: > - Patch 3: fix misleading comment about data truncate in the error path > of ext4_write_inline_data_end(). > > Thanks, > Yi. > > -------- > > Changes since v1: > > - Patch 1: add comments to explain why and how to update i_disksize in > ext4_da_write_end(). > - Patch 3: update i_disksize only if copied is not zero and drop > i_size_changed parameter, also drop unused EXT4_STATE_JDATA > and i_datasync_tid update code hook. > > Original description: > > This patchset address to improve buffer write performance with delalloc. > The first patch reduce the unnecessary update i_disksize, the second two > patch refactor the inline data write procedure and also do some small > fix, the last patch do improve by remove all unnecessary journal handle > in the delalloc write procedure. > > After this patch set, we could get a lot of performance improvement. > Below is the Unixbench comparison data test on my machine with 'Intel > Xeon Gold 5120' CPU and nvme SSD backend. > > Test cmd: > > ./Run -c 56 -i 3 fstime fsbuffer fsdisk > > Before this patch set: > > System Benchmarks Partial Index BASELINE RESULT INDEX > File Copy 1024 bufsize 2000 maxblocks 3960.0 422965.0 1068.1 > File Copy 256 bufsize 500 maxblocks 1655.0 105077.0 634.9 > File Copy 4096 bufsize 8000 maxblocks 5800.0 1429092.0 2464.0 > ======== > System Benchmarks Index Score (Partial Only) 1186.6 > > After this patch set: > > System Benchmarks Partial Index BASELINE RESULT INDEX > File Copy 1024 bufsize 2000 maxblocks 3960.0 732716.0 1850.3 > File Copy 256 bufsize 500 maxblocks 1655.0 184940.0 1117.5 > File Copy 4096 bufsize 8000 maxblocks 5800.0 2427152.0 4184.7 > ======== > System Benchmarks Index Score (Partial Only) 2053.0 > > > > > Zhang Yi (4): > ext4: check and update i_disksize properly > ext4: correct the error path of ext4_write_inline_data_end() > ext4: factor out write end code of inline file > ext4: drop unnecessary journal handle in delalloc write > > fs/ext4/ext4.h | 3 - > fs/ext4/inline.c | 120 ++++++++++++++++++------------------- > fs/ext4/inode.c | 150 ++++++++++++----------------------------------- > 3 files changed, 99 insertions(+), 174 deletions(-) >