From: Zhang Yi <yizhang089@gmail.com>
To: Guoqing Jiang <guoqing.jiang@linux.dev>,
tytso@mit.edu, adilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: remove tl argument from ext4_fc_replay_{add,del}_range
Date: Sat, 24 Jan 2026 16:07:10 +0800 [thread overview]
Message-ID: <5ebab91a-8510-40be-a77e-da17dca83e45@gmail.com> (raw)
In-Reply-To: <20260121063805.19863-1-guoqing.jiang@linux.dev>
On 1/21/2026 2:38 PM, Guoqing Jiang wrote:
> Since commit a7ba36bc94f2 ("ext4: fix fast commit alignment issues"),
> both ext4_fc_replay_add_range and ext4_fc_replay_del_range get
> ex based on 'val' instead of 'tl'.
>
> Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
Thank you for the cleanup, it looks good to me.
Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
> ---
> fs/ext4/fast_commit.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
> index fa66b08de999..8474ae52f8dd 100644
> --- a/fs/ext4/fast_commit.c
> +++ b/fs/ext4/fast_commit.c
> @@ -1751,8 +1751,7 @@ int ext4_fc_record_regions(struct super_block *sb, int ino,
> }
>
> /* Replay add range tag */
> -static int ext4_fc_replay_add_range(struct super_block *sb,
> - struct ext4_fc_tl_mem *tl, u8 *val)
> +static int ext4_fc_replay_add_range(struct super_block *sb, u8 *val)
> {
> struct ext4_fc_add_range fc_add_ex;
> struct ext4_extent newex, *ex;
> @@ -1872,8 +1871,7 @@ static int ext4_fc_replay_add_range(struct super_block *sb,
>
> /* Replay DEL_RANGE tag */
> static int
> -ext4_fc_replay_del_range(struct super_block *sb,
> - struct ext4_fc_tl_mem *tl, u8 *val)
> +ext4_fc_replay_del_range(struct super_block *sb, u8 *val)
> {
> struct inode *inode;
> struct ext4_fc_del_range lrange;
> @@ -2243,13 +2241,13 @@ static int ext4_fc_replay(journal_t *journal, struct buffer_head *bh,
> ret = ext4_fc_replay_unlink(sb, &tl, val);
> break;
> case EXT4_FC_TAG_ADD_RANGE:
> - ret = ext4_fc_replay_add_range(sb, &tl, val);
> + ret = ext4_fc_replay_add_range(sb, val);
> break;
> case EXT4_FC_TAG_CREAT:
> ret = ext4_fc_replay_create(sb, &tl, val);
> break;
> case EXT4_FC_TAG_DEL_RANGE:
> - ret = ext4_fc_replay_del_range(sb, &tl, val);
> + ret = ext4_fc_replay_del_range(sb, val);
> break;
> case EXT4_FC_TAG_INODE:
> ret = ext4_fc_replay_inode(sb, &tl, val);
prev parent reply other threads:[~2026-01-24 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 6:38 [PATCH] ext4: remove tl argument from ext4_fc_replay_{add,del}_range Guoqing Jiang
2026-01-24 8:07 ` Zhang Yi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ebab91a-8510-40be-a77e-da17dca83e45@gmail.com \
--to=yizhang089@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=guoqing.jiang@linux.dev \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox