[PATCH] ext4: remove tl argument from ext4_fc_replay_{add,del}_range

[PATCH] ext4: remove tl argument from ext4_fc_replay_{add,del}_range

[Guoqing Jiang]

Since commit a7ba36bc94f2 ("ext4: fix fast commit alignment issues"),
both ext4_fc_replay_add_range and ext4_fc_replay_del_range get
ex based on 'val' instead of 'tl'.

Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
---
 fs/ext4/fast_commit.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
index fa66b08de999..8474ae52f8dd 100644
--- a/fs/ext4/fast_commit.c
+++ b/fs/ext4/fast_commit.c
@@ -1751,8 +1751,7 @@ int ext4_fc_record_regions(struct super_block *sb, int ino,
 }
 
 /* Replay add range tag */
-static int ext4_fc_replay_add_range(struct super_block *sb,
-				    struct ext4_fc_tl_mem *tl, u8 *val)
+static int ext4_fc_replay_add_range(struct super_block *sb, u8 *val)
 {
 	struct ext4_fc_add_range fc_add_ex;
 	struct ext4_extent newex, *ex;
@@ -1872,8 +1871,7 @@ static int ext4_fc_replay_add_range(struct super_block *sb,
 
 /* Replay DEL_RANGE tag */
 static int
-ext4_fc_replay_del_range(struct super_block *sb,
-			 struct ext4_fc_tl_mem *tl, u8 *val)
+ext4_fc_replay_del_range(struct super_block *sb, u8 *val)
 {
 	struct inode *inode;
 	struct ext4_fc_del_range lrange;
@@ -2243,13 +2241,13 @@ static int ext4_fc_replay(journal_t *journal, struct buffer_head *bh,
 			ret = ext4_fc_replay_unlink(sb, &tl, val);
 			break;
 		case EXT4_FC_TAG_ADD_RANGE:
-			ret = ext4_fc_replay_add_range(sb, &tl, val);
+			ret = ext4_fc_replay_add_range(sb, val);
 			break;
 		case EXT4_FC_TAG_CREAT:
 			ret = ext4_fc_replay_create(sb, &tl, val);
 			break;
 		case EXT4_FC_TAG_DEL_RANGE:
-			ret = ext4_fc_replay_del_range(sb, &tl, val);
+			ret = ext4_fc_replay_del_range(sb, val);
 			break;
 		case EXT4_FC_TAG_INODE:
 			ret = ext4_fc_replay_inode(sb, &tl, val);
-- 
2.43.0

Re: [PATCH] ext4: remove tl argument from ext4_fc_replay_{add,del}_range

[Zhang Yi]

On 1/21/2026 2:38 PM, Guoqing Jiang wrote:
> Since commit a7ba36bc94f2 ("ext4: fix fast commit alignment issues"),
> both ext4_fc_replay_add_range and ext4_fc_replay_del_range get
> ex based on 'val' instead of 'tl'.
> 
> Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>

Thank you for the cleanup, it looks good to me.

Reviewed-by: Zhang Yi <yi.zhang@huawei.com>

> ---
>   fs/ext4/fast_commit.c | 10 ++++------
>   1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
> index fa66b08de999..8474ae52f8dd 100644
> --- a/fs/ext4/fast_commit.c
> +++ b/fs/ext4/fast_commit.c
> @@ -1751,8 +1751,7 @@ int ext4_fc_record_regions(struct super_block *sb, int ino,
>   }
>   
>   /* Replay add range tag */
> -static int ext4_fc_replay_add_range(struct super_block *sb,
> -				    struct ext4_fc_tl_mem *tl, u8 *val)
> +static int ext4_fc_replay_add_range(struct super_block *sb, u8 *val)
>   {
>   	struct ext4_fc_add_range fc_add_ex;
>   	struct ext4_extent newex, *ex;
> @@ -1872,8 +1871,7 @@ static int ext4_fc_replay_add_range(struct super_block *sb,
>   
>   /* Replay DEL_RANGE tag */
>   static int
> -ext4_fc_replay_del_range(struct super_block *sb,
> -			 struct ext4_fc_tl_mem *tl, u8 *val)
> +ext4_fc_replay_del_range(struct super_block *sb, u8 *val)
>   {
>   	struct inode *inode;
>   	struct ext4_fc_del_range lrange;
> @@ -2243,13 +2241,13 @@ static int ext4_fc_replay(journal_t *journal, struct buffer_head *bh,
>   			ret = ext4_fc_replay_unlink(sb, &tl, val);
>   			break;
>   		case EXT4_FC_TAG_ADD_RANGE:
> -			ret = ext4_fc_replay_add_range(sb, &tl, val);
> +			ret = ext4_fc_replay_add_range(sb, val);
>   			break;
>   		case EXT4_FC_TAG_CREAT:
>   			ret = ext4_fc_replay_create(sb, &tl, val);
>   			break;
>   		case EXT4_FC_TAG_DEL_RANGE:
> -			ret = ext4_fc_replay_del_range(sb, &tl, val);
> +			ret = ext4_fc_replay_del_range(sb, val);
>   			break;
>   		case EXT4_FC_TAG_INODE:
>   			ret = ext4_fc_replay_inode(sb, &tl, val);