From: Jeff Layton <jlayton@kernel.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: brauner@kernel.org, Andreas Dilger <adilger.kernel@dilger.ca>,
Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: fix decoding of raw_inode timestamps
Date: Thu, 13 Jul 2023 09:19:03 -0400 [thread overview]
Message-ID: <6097b2118e820af8d9ffee6b663c4e260158d62a.camel@kernel.org> (raw)
In-Reply-To: <20230713130434.GA3724752@mit.edu>
On Thu, 2023-07-13 at 09:04 -0400, Theodore Ts'o wrote:
> On Thu, Jul 13, 2023 at 06:48:04AM -0400, Jeff Layton wrote:
> >
> > The above output is what I get with the fix in place. Without this
> > patch, I get: ...
>
> Thanks!! It's good to know the _one_ kunit test we have is capable of
> detecting this. We have a patch series lined up to add our *second*
> unit test (for the block allocator) for the next merge window, and
> while our unit test coverage is still quite small, it's nice to know
> that it can detect problems --- and much faster than running xfstests. :-}
>
Yeah, it's pretty quick! I need to consider adding some tests for some
other areas that are difficult to view outside the kernel (the errseq_t
infrastructure comes to mind).
--
Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2023-07-13 13:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 15:02 [PATCH] ext4: fix decoding of raw_inode timestamps Jeff Layton
2023-07-12 15:32 ` Christian Brauner
2023-07-12 17:52 ` Theodore Ts'o
2023-07-12 18:09 ` Jeff Layton
2023-07-12 21:25 ` Theodore Ts'o
2023-07-13 10:48 ` Jeff Layton
2023-07-13 13:04 ` Theodore Ts'o
2023-07-13 13:19 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6097b2118e820af8d9ffee6b663c4e260158d62a.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox