From: yebin <yebin10@huawei.com>
To: Jan Kara <jack@suse.cz>
Cc: <tytso@mit.edu>, <adilger.kernel@dilger.ca>,
<linux-ext4@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next v4 3/3] ext4: simplify read_mmp_block fucntion
Date: Wed, 20 Oct 2021 10:53:42 +0800 [thread overview]
Message-ID: <616F84B6.4040307@huawei.com> (raw)
In-Reply-To: <20211019134952.GJ3255@quack2.suse.cz>
On 2021/10/19 21:49, Jan Kara wrote:
> On Tue 19-10-21 20:39:31, Ye Bin wrote:
>> This patch is according to Jan Kara's suggestion:
>> I guess I would just get rid of sb_getblk() in read_mmp_block() and always
>> expect valid bh passed. The only place that passes NULL bh after this
>> patch is one case in ext4_multi_mount_protect() and that can call
>> sb_getblk() on its own. That way we can also simplify read_mmp_block()
>> prototype to:
>>
>> static int read_mmp_block(struct super_block *sb, struct buffer_head *bh);
>>
>> Signed-off-by: Ye Bin <yebin10@huawei.com>
>> Reviewed-by: Jan Kara <jack@suse.cz>
> ...
>
>> @@ -289,7 +279,11 @@ int ext4_multi_mount_protect(struct super_block *sb,
>> goto failed;
>> }
>>
>> - retval = read_mmp_block(sb, &bh, mmp_block);
>> + bh = sb_getblk(sb, mmp_block);
>> + if (bh)
> ^^^^^^
>
> !bh here, please.
Sorry，it's my fault. I will fix it and test this patch set base on
linux mainline.
>
> Honza
>
prev parent reply other threads:[~2021-10-20 2:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 12:39 [PATCH -next v4 0/3] Fix some issues about mmp Ye Bin
2021-10-19 12:39 ` [PATCH -next v4 1/3] ext4: compare to local seq and nodename when check conflict Ye Bin
2021-10-19 12:39 ` [PATCH -next v4 2/3] ext4: remove useless bh_check variable Ye Bin
2021-10-19 12:39 ` [PATCH -next v4 3/3] ext4: simplify read_mmp_block fucntion Ye Bin
2021-10-19 13:49 ` Jan Kara
2021-10-20 2:53 ` yebin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=616F84B6.4040307@huawei.com \
--to=yebin10@huawei.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).