From: Anand Jain <anajain.sg@gmail.com>
To: Christoph Hellwig <hch@lst.de>, Zorro Lang <zlang@kernel.org>
Cc: Anand Jain <asj@kernel.org>, Filipe Manana <fdmanana@suse.com>,
"Darrick J. Wong" <djwong@kernel.org>,
fstests@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 01/13] dmflakey: override SCRATCH_DEV in _init_flakey
Date: Thu, 18 Dec 2025 00:59:50 +0800 [thread overview]
Message-ID: <62945fac-eab8-4e42-8f3b-dfdee66a1b15@gmail.com> (raw)
In-Reply-To: <20251212082210.23401-2-hch@lst.de>
> where to create the custome dm table.
typo
s/custome/custom/
> _cleanup_flakey()
> {
> # If dmsetup load fails then we need to make sure to do resume here
> # otherwise the umount will hang
> test -n "$NON_FLAKEY_LOGDEV" && $DMSETUP_PROG resume $FLAKEY_LOGNAME &> /dev/null
> test -n "$NON_FLAKEY_RTDEV" && $DMSETUP_PROG resume $FLAKEY_RTNAME &> /dev/null
> - $DMSETUP_PROG resume flakey-test > /dev/null 2>&1
> + test -n "$NON_FLAKEY_DEV" && $DMSETUP_PROG resume flakey-test > /dev/null 2>&1
flakey-test target? Appears to be a typo for $FLAKEY_NAME;
I'll send a separate patch fixing the existing bug.
The rest looks good.
Reviewed-by: Anand Jain <asj@kernel.org>
Thanks.
next prev parent reply other threads:[~2025-12-17 16:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 8:21 stop overriding SCRATCH_{,LOG,RT}DEV v2 Christoph Hellwig
2025-12-12 8:21 ` [PATCH 01/13] dmflakey: override SCRATCH_DEV in _init_flakey Christoph Hellwig
2025-12-12 20:11 ` Darrick J. Wong
2025-12-15 5:29 ` Christoph Hellwig
2025-12-15 19:41 ` Darrick J. Wong
2025-12-17 16:59 ` Anand Jain [this message]
2025-12-12 8:21 ` [PATCH 02/13] ext4/006: call e2fsck directly Christoph Hellwig
2025-12-12 20:02 ` Darrick J. Wong
2025-12-15 5:27 ` Christoph Hellwig
2025-12-15 19:42 ` Darrick J. Wong
2025-12-17 17:01 ` Anand Jain
2025-12-12 8:21 ` [PATCH 03/13] common: add a _check_dev_fs helper Christoph Hellwig
2025-12-17 17:01 ` Anand Jain
2025-12-12 8:21 ` [PATCH 04/13] ext4/032: use _check_dev_fs Christoph Hellwig
2025-12-17 17:02 ` Anand Jain
2025-12-12 8:21 ` [PATCH 05/13] generic/590: split XFS RT specific bits out Christoph Hellwig
2025-12-17 17:02 ` Anand Jain
2025-12-12 8:21 ` [PATCH 06/13] xfs/157: don't override SCRATCH_{,LOG,RT}DEV Christoph Hellwig
2025-12-12 8:21 ` [PATCH 07/13] xfs/185: don't use SCRATCH_{,RT}DEV helpers Christoph Hellwig
2025-12-12 8:21 ` [PATCH 08/13] xfs/424: don't use SCRATCH_DEV helpers Christoph Hellwig
2025-12-12 8:21 ` [PATCH 09/13] xfs/521: require a real SCRATCH_RTDEV Christoph Hellwig
2025-12-12 8:21 ` [PATCH 10/13] xfs/521: call _require_scratch_size Christoph Hellwig
2025-12-12 20:01 ` Darrick J. Wong
2025-12-12 8:21 ` [PATCH 11/13] xfs/528: require a real SCRATCH_RTDEV Christoph Hellwig
2025-12-12 20:00 ` Darrick J. Wong
2025-12-12 8:22 ` [PATCH 12/13] xfs/530: " Christoph Hellwig
2025-12-12 20:00 ` Darrick J. Wong
2025-12-12 8:22 ` [PATCH 13/13] xfs/650: " Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2025-12-18 7:29 stop overriding SCRATCH_{,LOG,RT}DEV v3 Christoph Hellwig
2025-12-18 7:29 ` [PATCH 01/13] dmflakey: override SCRATCH_DEV in _init_flakey Christoph Hellwig
2025-12-18 21:27 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62945fac-eab8-4e42-8f3b-dfdee66a1b15@gmail.com \
--to=anajain.sg@gmail.com \
--cc=asj@kernel.org \
--cc=djwong@kernel.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).