public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Dilger <aedilger@gmail.com>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: "tytso@mit.edu" <tytso@mit.edu>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
	Yongqiang Yang <xiaoqiangnk@gmail.com>
Subject: Re: [PATCH] mke2fs: correct help text for option -G of mke2fs
Date: Wed, 4 Jan 2012 00:22:58 -0700	[thread overview]
Message-ID: <65F5DCD8-3B25-4F40-8966-2C23700E0CDA@gmail.com> (raw)
In-Reply-To: <1325647785-8672-1-git-send-email-xiaoqiangnk@gmail.com>

Probably "flex_group_size" or "flex_group_factor" is as clear and a lot shorter. 

Cheers, Andreas

On 2012-01-03, at 20:29, Yongqiang Yang <xiaoqiangnk@gmail.com> wrote:

> The option '-G' is used to pass number of groups in a flex_bg, the
> previous help text - 'meta-group-size' - could confuse users with
> meta_bg.
> 
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
> ---
> misc/mke2fs.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/misc/mke2fs.c b/misc/mke2fs.c
> index 0ef2531..52746fe 100644
> --- a/misc/mke2fs.c
> +++ b/misc/mke2fs.c
> @@ -116,7 +116,7 @@ static void usage(void)
>    fprintf(stderr, _("Usage: %s [-c|-l filename] [-b block-size] "
>    "[-C cluster-size]\n\t[-i bytes-per-inode] [-I inode-size] "
>    "[-J journal-options]\n"
> -    "\t[-G meta group size] [-N number-of-inodes]\n"
> +    "\t[-G number-of-groups-per-flex_bg] [-N number-of-inodes]\n"
>    "\t[-m reserved-blocks-percentage] [-o creator-os]\n"
>    "\t[-g blocks-per-group] [-L volume-label] "
>    "[-M last-mounted-directory]\n\t[-O feature[,...]] "
> -- 
> 1.7.5.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2012-01-04  7:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-04  3:29 [PATCH] mke2fs: correct help text for option -G of mke2fs Yongqiang Yang
2012-01-04  7:22 ` Andreas Dilger [this message]
2012-01-04  7:47   ` Yongqiang Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65F5DCD8-3B25-4F40-8966-2C23700E0CDA@gmail.com \
    --to=aedilger@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=xiaoqiangnk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox