From: Curt Wohlgemuth <curtw@google.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Subject: [PATCH] ext4: Ensure zeroout blocks have no dirty metadata
Date: Thu, 10 Dec 2009 09:28:28 -0800 [thread overview]
Message-ID: <6601abe90912100928v747671dat489aeee5dabf2c03@mail.gmail.com> (raw)
This fixes a bug in which new blocks returned from an extent created with
ext4_ext_zeroout() can have dirty metadata still associated with them.
Signed-off-by: Curt Wohlgemuth <curtw@google.com>
---
This is for the problem I reported on 23 Nov ("Bug in extent zeroout: blocks
not marked as new"). I'm not seeing the corruption with this fix that I was
seeing without it.
diff -uprN orig/fs/ext4/extents.c new/fs/ext4/extents.c
--- orig/fs/ext4/extents.c 2009-12-09 15:09:25.000000000 -0800
+++ new/fs/ext4/extents.c 2009-12-09 15:09:37.000000000 -0800
@@ -2474,9 +2474,21 @@ static int ext4_ext_zeroout(struct inode
submit_bio(WRITE, bio);
wait_for_completion(&event);
- if (test_bit(BIO_UPTODATE, &bio->bi_flags))
+ /* On success, we need to insure all metadata associated
+ * with each of these blocks is unmapped. */
+ if (test_bit(BIO_UPTODATE, &bio->bi_flags)) {
+ sector_t block = ee_pblock;
+
ret = 0;
- else {
+ done = 0;
+ while (done < len) {
+ unmap_underlying_metadata(inode->i_sb->s_bdev,
+ block);
+
+ done++;
+ block++;
+ }
+ } else {
ret = -EIO;
break;
}
next reply other threads:[~2009-12-10 17:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 17:28 Curt Wohlgemuth [this message]
2009-12-10 17:44 ` [PATCH] ext4: Ensure zeroout blocks have no dirty metadata Eric Sandeen
2009-12-10 18:01 ` Curt Wohlgemuth
2009-12-11 9:09 ` Andreas Dilger
2009-12-11 22:01 ` Curt Wohlgemuth
2009-12-11 23:27 ` Andreas Dilger
2009-12-15 22:33 ` Curt Wohlgemuth
2009-12-18 11:49 ` Aneesh Kumar K.V
2009-12-18 12:10 ` Aneesh Kumar K.V
2009-12-18 23:11 ` Curt Wohlgemuth
2009-12-29 17:56 ` Curt Wohlgemuth
2009-12-29 18:53 ` tytso
2009-12-29 23:23 ` Curt Wohlgemuth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6601abe90912100928v747671dat489aeee5dabf2c03@mail.gmail.com \
--to=curtw@google.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox