From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 286E2C63777 for ; Thu, 3 Dec 2020 09:59:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE053206CA for ; Thu, 3 Dec 2020 09:59:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388536AbgLCJ6p convert rfc822-to-8bit (ORCPT ); Thu, 3 Dec 2020 04:58:45 -0500 Received: from smtp.h3c.com ([60.191.123.50]:59635 "EHLO h3cspam02-ex.h3c.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388483AbgLCJ6o (ORCPT ); Thu, 3 Dec 2020 04:58:44 -0500 X-Greylist: delayed 6058 seconds by postgrey-1.27 at vger.kernel.org; Thu, 03 Dec 2020 04:58:42 EST Received: from h3cspam02-ex.h3c.com (localhost [127.0.0.2] (may be forged)) by h3cspam02-ex.h3c.com with ESMTP id 0B38Hgsh099569 for ; Thu, 3 Dec 2020 16:17:42 +0800 (GMT-8) (envelope-from tian.xianting@h3c.com) Received: from DAG2EX05-BASE.srv.huawei-3com.com ([10.8.0.68]) by h3cspam02-ex.h3c.com with ESMTP id 0B38FxA0095873; Thu, 3 Dec 2020 16:15:59 +0800 (GMT-8) (envelope-from tian.xianting@h3c.com) Received: from DAG2EX03-BASE.srv.huawei-3com.com (10.8.0.66) by DAG2EX05-BASE.srv.huawei-3com.com (10.8.0.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 3 Dec 2020 16:16:02 +0800 Received: from DAG2EX03-BASE.srv.huawei-3com.com ([fe80::5d18:e01c:bbbd:c074]) by DAG2EX03-BASE.srv.huawei-3com.com ([fe80::5d18:e01c:bbbd:c074%7]) with mapi id 15.01.2106.002; Thu, 3 Dec 2020 16:16:02 +0800 From: Tianxianting To: Jan Kara , "tytso@mit.edu" CC: "adilger.kernel@dilger.ca" , "linux-ext4@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] ext4: remove the null check of bio_vec page Thread-Topic: [PATCH] ext4: remove the null check of bio_vec page Thread-Index: AQHWpruDhYzwIts0bkGkoCqDPV0JCqmhVUyAgAQSuiD//39fAIBAY6/Q Date: Thu, 3 Dec 2020 08:16:01 +0000 Message-ID: <6859d08c4dd44de9b7a040c160046359@h3c.com> References: <20201020082201.34257-1-tian.xianting@h3c.com> <20201021102503.GC19726@quack2.suse.cz> <113ad7d2cbfd43a9972ad37df66e5542@h3c.com> <20201023165644.GG9119@quack2.suse.cz> In-Reply-To: <20201023165644.GG9119@quack2.suse.cz> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.99.141.128] x-sender-location: DAG2 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-DNSRBL: X-MAIL: h3cspam02-ex.h3c.com 0B38FxA0095873 Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Thanks Jan Hi Ted Tso, Could I get your opinion of this patch? thanks -----Original Message----- From: Jan Kara [mailto:jack@suse.cz] Sent: Saturday, October 24, 2020 12:57 AM To: tianxianting (RD) Cc: Jan Kara ; tytso@mit.edu; adilger.kernel@dilger.ca; linux-ext4@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: remove the null check of bio_vec page On Fri 23-10-20 16:38:16, Tianxianting wrote: > Thanks Jan > Can be the patch applied? Ted Tso is the ext4 maintainer so he should eventually pick up and apply the patch. But since there's merge window currently open, I guess he's busy shuffling patches to send to Linus. I'd expect he'll get to your patch in a week or two. Honza > > -----Original Message----- > From: Jan Kara [mailto:jack@suse.cz] > Sent: Wednesday, October 21, 2020 6:25 PM > To: tianxianting (RD) > Cc: tytso@mit.edu; adilger.kernel@dilger.ca; jack@suse.cz; > linux-ext4@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] ext4: remove the null check of bio_vec page > > On Tue 20-10-20 16:22:01, Xianting Tian wrote: > > bv_page can't be NULL in a valid bio_vec, so we can remove the NULL > > check, as we did in other places when calling > > bio_for_each_segment_all() to go through all bio_vec of a bio. > > > > Signed-off-by: Xianting Tian > > Thanks for the patch. It looks good to me. You can add: > > Reviewed-by: Jan Kara > > Honza > > > --- > > fs/ext4/page-io.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c index > > defd2e10d..cb135a944 100644 > > --- a/fs/ext4/page-io.c > > +++ b/fs/ext4/page-io.c > > @@ -111,9 +111,6 @@ static void ext4_finish_bio(struct bio *bio) > > unsigned under_io = 0; > > unsigned long flags; > > > > - if (!page) > > - continue; > > - > > if (fscrypt_is_bounce_page(page)) { > > bounce_page = page; > > page = fscrypt_pagecache_page(bounce_page); > > -- > > 2.17.1 > > > -- > Jan Kara > SUSE Labs, CR -- Jan Kara SUSE Labs, CR