RE: [PATCH] ext4: remove the null check of bio_vec page

Tianxianting
2020-12-04T01:29:12Z

Thanks Ted :)

-----Original Message-----
From: Theodore Y. Ts'o [mailto:tytso@mit.edu]
Sent: Thursday, December 03, 2020 10:11 PM
To: Jan Kara <jack@suse.cz>
Cc: tianxianting (RD) <tian.xianting@h3c.com>; adilger.kernel@dilger.ca; linux-ext4@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: remove the null check of bio_vec page

On Wed, Oct 21, 2020 at 12:25:03PM +0200, Jan Kara wrote:
> On Tue 20-10-20 16:22:01, Xianting Tian wrote:
> > bv_page can't be NULL in a valid bio_vec, so we can remove the NULL
> > check, as we did in other places when calling
> > bio_for_each_segment_all() to go through all bio_vec of a bio.
> >
> > Signed-off-by: Xianting Tian <tian.xianting@h3c.com>
>
> Thanks for the patch. It looks good to me. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>

Applied, thanks.

- Ted