From: Martin Steigerwald <martin@lichtvoll.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Bart.VanAssche@wdc.com, dvyukov@google.com,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
jthumshirn@suse.de, alan.christopher.jenkins@gmail.com,
syzbot+c4f9cebf9d651f6e54de@syzkaller.appspotmail.com,
martin.petersen@oracle.com, dan.j.williams@intel.com, hch@lst.de,
oleksandr@natalenko.name, hare@suse.com,
syzkaller-bugs@googlegroups.com, ross.zwisler@linux.intel.com,
keith.busch@intel.com, linux-ext4@vger.kernel.org
Subject: Re: INFO: task hung in blk_queue_enter
Date: Sat, 02 Jun 2018 10:07:26 +0200 [thread overview]
Message-ID: <6992049.xPdnW5VfcJ@merkaba> (raw)
In-Reply-To: <20180602045353.GA20257@ming.t460p>
Ming Lei - 02.06.18, 06:54:
> On Fri, Jun 01, 2018 at 10:31:13PM -0600, Jens Axboe wrote:
> > On 6/1/18 8:36 PM, Ming Lei wrote:
> > >> clear the bit when we need to, potentially even adding a debug
> > >> check to blk_queue_enter_live() that complains if the ref was
> > >> not already elevated. Though that would be expensive, compared
> > >> to the percpu inc now. Not saying the bit is necessarily the
> > >> best way forward, but I do like it a LOT more than adding an
> > >> argument to generic_make_request.> >
> > > We may introduce generic_make_request_with_ref() for
> > > blk_queue_split(), what do you think of the following patch?
> >
> > Functionally it'll work as well.
>
> If you are fine with this one, I'm glad to prepare for a normal one,
> so that we can save one precious bio flag, and the total number is
> just 13.
[…]
I am completely lost about what you are talking about.
That is fine with me, but in case there is anything to test… let me
know. I do not promise quick responses tough, as I have been quite a bit
overwhelmed with stuff lately.
Currently I run 4.17-rc7 without any blk-mq related patches and it
appears to be free of hangs or stalls related to blk-mq.
Thanks,
--
Martin
next prev parent reply other threads:[~2018-06-02 8:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0000000000009b212b056ae6dbad@google.com>
2018-05-15 11:45 ` INFO: task hung in blk_queue_enter Tetsuo Handa
2018-05-16 13:05 ` Tetsuo Handa
2018-05-16 14:56 ` Bart Van Assche
2018-05-16 15:16 ` Dmitry Vyukov
2018-05-16 15:37 ` Bart Van Assche
2018-05-21 21:52 ` Tetsuo Handa
2018-05-22 11:20 ` Tetsuo Handa
2018-06-01 10:10 ` Tetsuo Handa
2018-06-01 17:52 ` Jens Axboe
2018-06-01 23:49 ` Ming Lei
2018-06-02 0:49 ` Jens Axboe
2018-06-02 0:56 ` Jens Axboe
2018-06-02 2:36 ` Ming Lei
2018-06-02 4:31 ` Jens Axboe
2018-06-02 4:54 ` Ming Lei
2018-06-02 8:07 ` Martin Steigerwald [this message]
2018-06-02 13:48 ` Jens Axboe
2018-06-05 0:27 ` Tetsuo Handa
2018-06-05 0:41 ` Ming Lei
2018-06-07 3:29 ` Ming Lei
2018-06-07 13:19 ` Tetsuo Handa
2018-06-04 11:46 ` Dmitry Vyukov
2018-06-04 13:13 ` Tetsuo Handa
2018-05-16 17:33 ` Alan Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6992049.xPdnW5VfcJ@merkaba \
--to=martin@lichtvoll.de \
--cc=Bart.VanAssche@wdc.com \
--cc=alan.christopher.jenkins@gmail.com \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=dvyukov@google.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=oleksandr@natalenko.name \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=ross.zwisler@linux.intel.com \
--cc=syzbot+c4f9cebf9d651f6e54de@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).