Re: [PATCH v3] ext4: fix mballoc-test.c is not compiled when EXT4_KUNIT_TESTS=M

["yebin (H)" <yebin10@huawei.com>]

On 2026/3/6 17:55, Ojaswin Mujoo wrote:
> On Fri, Feb 27, 2026 at 02:55:14PM +0800, Ye Bin wrote:
>> From: Ye Bin <yebin10@huawei.com>
>>
>> Now, only EXT4_KUNIT_TESTS=Y testcase will be compiled in 'mballoc.c'.
>> To solve this issue, the ext4 test code needs to be decoupled. The ext4
>> test module is compiled into a separate module.
>>
>> Reported-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
>> Closes: https://patchwork.kernel.org/project/cifs-client/patch/20260118091313.1988168-2-chenxiaosong.chenxiaosong@linux.dev/
>> Fixes: 7c9fa399a369 ("ext4: add first unit test for ext4_mb_new_blocks_simple in mballoc")
>> Signed-off-by: Ye Bin <yebin10@huawei.com>
>
> Hi Ye,
>
>>From my testing I can see that EXPORT_SYMBOL_FOR_MODULE() doesn't
> resepect the namespace restriction if EXT4_KUNIT_TESTS=y but I think
> that should be okay.
>
> The patch otherwise looks good. Feel free to add:
>
> Reviewed-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
>
> One thing, recently added extents-test.c is also having the same issue where
> it doesn't work when compiled as module. Would you be willing to fix it
> as well?
>
No problem, I will fix this issue.
> Regards,
> ojaswin
>
>
>
> .
>