From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from canpmsgout10.his.huawei.com (canpmsgout10.his.huawei.com [113.46.200.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B95E17D6 for ; Sat, 7 Mar 2026 00:03:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.225 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772841787; cv=none; b=ZFqKOC6GuRyw3vAFiI8zheb7fjVWBolImJdKWzOyhn4dSFNdrwa+I0yH3hrQSVkjFhQGbkst0Rp5kXYdyD3R882P8bHPlKtjrkFeCmIxdxYpMf27RIV/1fto+SLS9epqfbfeajyH5FSOJ+uZNUI0sw+20VyHhexEkYR5IYDxrak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772841787; c=relaxed/simple; bh=ZVLoZpgAlw0ScJhMYKkGxbBxgzWdaD+QAyf9hVyizWw=; h=Subject:To:References:CC:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=TAClVtqiDYkP9cYXuWrW2t/KVLo+hCVjEVRgtz+kpNizvCyqituWzQ4CIKk0cd+sqgmdHm8bq8LuI6deKogfHenYTabCBa6NGF1j0u+RlUHLo9cTZ/mbdXdjUc9vukStlof/veinUDjNV7ZZD9ffxxVFaTytagiK39R4f3Ex6/E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=IVf10wvc; arc=none smtp.client-ip=113.46.200.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="IVf10wvc" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=ZVLoZpgAlw0ScJhMYKkGxbBxgzWdaD+QAyf9hVyizWw=; b=IVf10wvc05V0wrZqf3y2gTwZUaHv7UK0eizSWSNSlt8Oolw2UfG565Ljx0DUpzhMFvkQ4y0PY 17w1IW4HEfaQ6RwLj0kJm6EB3GWoN+1BwG0PWTO7Q0y1jMNg+Y+umKvuEoMZ/qlOOrkQD/vf5ce FgiViKbrPRBUjZgsh18XyTg= Received: from mail.maildlp.com (unknown [172.19.163.200]) by canpmsgout10.his.huawei.com (SkyGuard) with ESMTPS id 4fSNdT3MBRz1K9YC; Sat, 7 Mar 2026 07:58:05 +0800 (CST) Received: from dggemv706-chm.china.huawei.com (unknown [10.3.19.33]) by mail.maildlp.com (Postfix) with ESMTPS id D134D4055B; Sat, 7 Mar 2026 08:02:55 +0800 (CST) Received: from kwepemq500016.china.huawei.com (7.202.194.202) by dggemv706-chm.china.huawei.com (10.3.19.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 7 Mar 2026 08:02:55 +0800 Received: from [10.174.178.185] (10.174.178.185) by kwepemq500016.china.huawei.com (7.202.194.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 7 Mar 2026 08:02:54 +0800 Subject: Re: [PATCH v3] ext4: fix mballoc-test.c is not compiled when EXT4_KUNIT_TESTS=M To: Ojaswin Mujoo , Ye Bin References: <20260227065514.2365063-1-yebin@huaweicloud.com> CC: , , , From: "yebin (H)" Message-ID: <69AB6B2D.6070006@huawei.com> Date: Sat, 7 Mar 2026 08:02:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: kwepems100002.china.huawei.com (7.221.188.206) To kwepemq500016.china.huawei.com (7.202.194.202) On 2026/3/6 17:55, Ojaswin Mujoo wrote: > On Fri, Feb 27, 2026 at 02:55:14PM +0800, Ye Bin wrote: >> From: Ye Bin >> >> Now, only EXT4_KUNIT_TESTS=Y testcase will be compiled in 'mballoc.c'. >> To solve this issue, the ext4 test code needs to be decoupled. The ext4 >> test module is compiled into a separate module. >> >> Reported-by: ChenXiaoSong >> Closes: https://patchwork.kernel.org/project/cifs-client/patch/20260118091313.1988168-2-chenxiaosong.chenxiaosong@linux.dev/ >> Fixes: 7c9fa399a369 ("ext4: add first unit test for ext4_mb_new_blocks_simple in mballoc") >> Signed-off-by: Ye Bin > > Hi Ye, > >>>From my testing I can see that EXPORT_SYMBOL_FOR_MODULE() doesn't > resepect the namespace restriction if EXT4_KUNIT_TESTS=y but I think > that should be okay. > > The patch otherwise looks good. Feel free to add: > > Reviewed-by: Ojaswin Mujoo > > One thing, recently added extents-test.c is also having the same issue where > it doesn't work when compiled as module. Would you be willing to fix it > as well? > No problem, I will fix this issue. > Regards, > ojaswin > > > > . >