public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: zhanchengbin <zhanchengbin1@huawei.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: <linux-ext4@vger.kernel.org>, <liuzhiqiang26@huawei.com>,
	<linfeilong@huawei.com>
Subject: [PATCH 3/6] lib/support: check whether inump is null before accessing it in quota_set_sb_inum()
Date: Fri, 3 Dec 2021 14:28:52 +0800	[thread overview]
Message-ID: <71ed1c9e-7e23-9f73-e7b9-55810963f4f3@huawei.com> (raw)
In-Reply-To: <37c58382-9714-7e99-6c4d-01b78cfdbd26@huawei.com>

In quota_set_sb_inum(), we should check whether inump is null before 
accessing it,
otherwise the null potinter dereference error may occur.

Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
---
  lib/support/mkquota.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/support/mkquota.c b/lib/support/mkquota.c
index 6f4a0b90..482e3d91 100644
--- a/lib/support/mkquota.c
+++ b/lib/support/mkquota.c
@@ -99,7 +99,8 @@ void quota_set_sb_inum(ext2_filsys fs, ext2_ino_t ino, 
enum quota_type qtype)

      log_debug("setting quota ino in superblock: ino=%u, type=%d", ino,
           qtype);
-    *inump = ino;
+    if (inump != NULL)
+        *inump = ino;
      ext2fs_mark_super_dirty(fs);
  }

-- 
2.23.0

  parent reply	other threads:[~2021-12-03  6:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03  6:24 [PATCH 0/6] solve memory leak and check whether NULL pointer zhanchengbin
2021-12-03  6:26 ` [PATCH 1/6] e2fsck: set s->len=0 if malloc() fails in alloc_string() zhanchengbin
2021-12-03  6:31   ` Zhiqiang Liu
2021-12-03  6:27 ` [PATCH 2/6] lib/ss: check whether argp is null before accessing it in ss_execute_command() zhanchengbin
2021-12-03  6:28 ` zhanchengbin [this message]
2021-12-03  6:29 ` [PATCH 4/6] e2fsprogs: call ext2fs_badblocks_list_free() to free list in exception branch zhanchengbin
2021-12-03  6:30 ` [PATCH 5/6] e2fsck: check whether ldesc is null before accessing it in end_problem_latch() zhanchengbin
2021-12-03  6:31 ` [PATCH 6/6] lib/ext2fs: call ext2fs_free_mem() to free &io->name in exception branch zhanchengbin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71ed1c9e-7e23-9f73-e7b9-55810963f4f3@huawei.com \
    --to=zhanchengbin1@huawei.com \
    --cc=linfeilong@huawei.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=liuzhiqiang26@huawei.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox