From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94CB0369979 for ; Mon, 2 Mar 2026 13:24:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772457856; cv=none; b=LpkrBRfTHUJHM5HwknU5pPKvarkpl3iJo6wBLxOeuRnXcyhiBxQKoKYiWShW1OTlAPDy96pV/jYH1XdB/0SGh2pDO20CAQY/XLNBY2577bHFlnat038eIKAwg9Ac9BvakuXKGfKnUAIFwIZlCvXjI5JDR3PfJsAszyEX7CZdHe4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772457856; c=relaxed/simple; bh=ltfsj99I78ai3Uw4cmgHT0d1UXB8XXPY1S98SmQRKs0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p9Oec/0sWX0Is/nLYYKVcsE9TnoC09IN+NP/HDTyr4x1vvw61bISgxo1J0vldtDsZEQlTgkn4HacmOjWFzYjis97zHNaSd29c4GCObmK7SqhyJcRWT4mWco+Jz/mVnhguWlhSQQ6JUXUwJRHW/eVdv4bpVcs4SNZsUdN2k8C0l4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LueOPztv; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LueOPztv" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-8273eb7798eso1908536b3a.1 for ; Mon, 02 Mar 2026 05:24:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772457849; x=1773062649; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v9ZnDEvgwTfM42XxCeWf1ZWhMQzzUDLYvt9awp7GUwc=; b=LueOPztvjLS8TwLVZEA7S/Gqx4FUAvlFDty0m5Ywooe7fOv98qYJW5jZgNLf+dBVXL LDHJBQaDuMOVCpSXyW1+Ifxtrxx1k5aBtNnH2bops36EEp5mcPiOPW1dijZj1Czhbdp/ pZsaRzkSCMd1BdzxeRCthPqHRcn1DA6jZyy40+TlkrDM7menZPM6nH5P6RmWYEn14G4q mjcww6g4kmG1tdsC21C6nJlZYWHEXqKLEHd/cI70mBkKIt6yI8nFQYdhYyvAi4oj8qQH SKzV6RYep9VvN8RxJ5zmEyG44P3uYDiHRi8gHza32G3OS+HmEVQiquxEOGUwSF3IT4nI HL1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772457849; x=1773062649; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v9ZnDEvgwTfM42XxCeWf1ZWhMQzzUDLYvt9awp7GUwc=; b=BOOf5wG4keLqVIFEPWl0MtAFrcqaVHOVA1I0z7pJVhcAsVcqhmsbkhfWmn0P7BbMVW tGBd7VVfyticwMHrHhBIN9Ct4f+ZBry/T6azRN3AI20gB+1H5uL9tiYoYaNEMDbmsGkJ /0OY4WgDljJShG/QnSI9EiokQU1cHrshMxD4VVNVwUbejxLjVBUDnocWzvhs5VbbpZjv +W+kmDv7ZmlPgK3u4oPBFQAKfmIHAQ9lhNdsnOax2TgaE+PMto0P98tpiy1j5AUJKeTS eX6ZXA0nHTmeSaqM89PVppfv7wRf19FT0uS/L6M7i9nECJSvGro0J2pvQo7PY3NkeRkA /ksA== X-Forwarded-Encrypted: i=1; AJvYcCW8n2d6gGlN/zsCRb2pTvXom8kOgW4mx47BCcR5t8n/NDfkY1IZ5kbfOgGrUKVSKQkwzz97npHJb0qO@vger.kernel.org X-Gm-Message-State: AOJu0YxrUWYoVVWAFAC3x2nmGz/52hwpP6BwcNqQrGg1hvyP1rBsGTwe gSIPhZsouejGDqAIyWruB+yz80KlWqlV+wSEpi8r+hlGksa4tIPI/DKn X-Gm-Gg: ATEYQzyVH2CUUeqJo+LlOZrJKgIMpIReluuuaK860f0L0Xc2504m3Ou9AnKB5GH9Sr/ UJHQzeuGx4paboRaZvnXl5HItg6kn1N8OPiAShHfYRpFUenvCZTVbszaNa/TrDWN1z68WQnWK1D rzhjF5fNK8VwQWXekWWVzzHDTK8Hj3n4mdnrZ6NlA27r4LK3ZRPDfLIVx6dwU/HV5IuJESopCZ0 t7N2B499epKXGl2zmKajHW4MaA5xnNENMWPWlsCA93+8SGmUbV3Ur5KRiRIoY7BZEqIqtZ94Z39 51ut0gLvIeTlw7fptI2aZOHxtMt+GM631RBdBQKBKSuxKRdqJI2z2z7daqFLQHAB0JZqRykJPlR XFw4TXSNQjPgS/iTRt5rsCFqcqkMwzzL9LYkrOr/AQle/wUs7vdTt2LBQI148rzRQyz0ANevYZt XHAU1o5H9dZJpgcwuLF/m0PZVpNbw= X-Received: by 2002:a05:6a00:3a25:b0:827:2891:c177 with SMTP id d2e1a72fcca58-8274da2fee7mr8658465b3a.64.1772457848572; Mon, 02 Mar 2026 05:24:08 -0800 (PST) Received: from [192.168.50.90] ([116.87.14.48]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8273a05e831sm13446967b3a.58.2026.03.02.05.24.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 05:24:08 -0800 (PST) Message-ID: <73e51635-e461-4292-a858-f73ea4d23545@gmail.com> Date: Mon, 2 Mar 2026 21:24:05 +0800 Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/9] fstests: add test for inotify isolation on cloned devices To: Amir Goldstein , Anand Jain Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, Jan Kara References: <78014ba3d564004081dca3c1d7e69cec8943f629.1772095513.git.asj@kernel.org> Content-Language: en-US From: Anand Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit >> +_cleanup() >> +{ >> + cd / >> + rm -r -f $tmp.* >> + umount $mnt1 $mnt2 2>/dev/null >> + _scratch_dev_pool_put >> +} >> + >> +_scratch_dev_pool_get 2 >> +_scratch_mkfs_sized_clone >$seqres.full 2>&1 >> +devs=($SCRATCH_DEV_POOL) >> +mnt2=$TEST_DIR/mnt2 >> +mkdir -p $mnt2 >> + >> +_scratch_mount $(_clone_mount_option) >> +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[1]} $mnt2 || \ >> + _fail "Failed to mount dev2" >> + >> +log1=$tmp.inotify1 >> +log2=$tmp.inotify2 >> + >> +echo "Setup inotify watchers on both SCRATCH_MNT and mnt2" >> +$INOTIFYWAIT_PROG -m -e create --format '%f' $SCRATCH_MNT > $log1 2>&1 & >> +pid1=$! >> +$INOTIFYWAIT_PROG -m -e create --format '%f' $mnt2 > $log2 2>&1 & >> +pid2=$! >> +sleep 2 >> + >> +echo "Trigger file creation on SCRATCH_MNT" >> +touch $SCRATCH_MNT/file_on_scratch_mnt >> +sync >> +sleep 1 >> + >> +echo "Trigger file creation on mnt2" >> +touch $mnt2/file_on_mnt2 >> +sync >> +sleep 1 >> + >> +echo "Verify inotify isolation" >> +kill $pid1 $pid2 >> +wait $pid1 $pid2 2>/dev/null > > I think you also need to take care of killing the bg process > in _cleanup() so that the test could be cleanly aborted. You are right, SIGINT can terminate the testcase at any point, we need kill(1) in _cleanup(). I'll fix this in v2. Thanks, Anand