Re: [PATCH] Fixed commit: Fixes Sphinx warnings about duplicate reference labels in Documentation/filesystems/ext4/atomic_writes.rst.

[Randy Dunlap <rdunlap@infradead.org>]

Andre,

The warnings should be part of the patch description, not in the patch itself.

Still missing the actual ext4 change.

More below.


On 7/28/25 6:32 PM, Andre Luiz da Nobrega wrote:
> Specifically, the label '.. _atomic_write_bdev_support:' was renamed to
> '.. _atomic_write_bdev_support_section:' to ensure label uniqueness
> within the document.
> 
> Signed-off-by: Andre Luiz da Nobrega <andreluizrodriguescastro@gmail.com>
> ---
>  Documentation/filesystems/ext4/atomic_writes.rst |  2 +-
>  warn_output.txt                                  | 12 ++++++++++++
>  2 files changed, 13 insertions(+), 1 deletion(-)
>  create mode 100644 warn_output.txt
> 
> diff --git a/Documentation/filesystems/ext4/atomic_writes.rst b/Documentation/filesystems/ext4/atomic_writes.rst
> index 80f83112d24d..e8cf983049b4 100644
> --- a/Documentation/filesystems/ext4/atomic_writes.rst
> +++ b/Documentation/filesystems/ext4/atomic_writes.rst
> @@ -204,7 +204,7 @@ writes are supported.
>  .. _atomic_write_bdev_support_section:
>  
>  Hardware Support
> -----------------
> +-----------------

Unneeded change?

>  
>  The underlying storage device must support atomic write operations.
>  Modern NVMe and SCSI devices often provide this capability.
> diff --git a/warn_output.txt b/warn_output.txt
> new file mode 100644
> index 000000000000..593c6fa5b65d
> --- /dev/null
> +++ b/warn_output.txt
> @@ -0,0 +1,12 @@
> +Using alabaster theme
> +^[[91m/home/alkaleus/Documentos/PESSOAL/LFX_dev/linus_tree/Documentation/filesystems/ext4/atomic_writes.rst:5: WARNING: duplicate label atomic_writes, other instance in /home/alkaleus/Documentos/PESSOAL/LFX_dev/linus_tree/Documentation/filesystems/ext4/atomic_writes.rst^[[39;49;00m
> +^[[91m/home/alkaleus/Documentos/PESSOAL/LFX_dev/linus_tree/Documentation/filesystems/ext4/atomic_writes.rst:207: WARNING: duplicate label atomic_write_bdev_support, other instance in /home/alkaleus/Documentos/PESSOAL/LFX_dev/linus_tree/Documentation/filesystems/ext4/atomic_writes.rst^[[39;49;00m
> +^[[91mWARNING: ./drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:1068 struct member 'mcm' not described in 'mpc_funcs'^[[39;49;00m
> +^[[91mWARNING: ./drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:1068 struct member 'rmcm' not described in 'mpc_funcs'^[[39;49;00m
> +^[[91m/home/alkaleus/Documentos/PESSOAL/LFX_dev/linus_tree/Documentation/gpu/drm-kms:360: ./drivers/gpu/drm/drm_fourcc.c:362: WARNING: Duplicate C declaration, also defined at gpu/drm-kms:35.
> +Declaration is '.. c:function:: const struct drm_format_info * drm_format_info (u32 format)'.^[[39;49;00m
> +^[[91m/home/alkaleus/Documentos/PESSOAL/LFX_dev/linus_tree/Documentation/gpu/drm-kms:476: ./drivers/gpu/drm/drm_modeset_lock.c:375: WARNING: Duplicate C declaration, also defined at gpu/drm-kms:49.
> +Declaration is '.. c:function:: int drm_modeset_lock (struct drm_modeset_lock *lock, struct drm_modeset_acquire_ctx *ctx)'.^[[39;49;00m
> +^[[91m/home/alkaleus/Documentos/PESSOAL/LFX_dev/linus_tree/Documentation/gpu/drm-uapi:557: ./drivers/gpu/drm/drm_ioctl.c:915: WARNING: Duplicate C declaration, also defined at gpu/drm-uapi:70.
> +Declaration is '.. c:function:: bool drm_ioctl_flags (unsigned int nr, unsigned int *flags)'.^[[39;49;00m
> +^[[91m/home/alkaleus/Documentos/PESSOAL/LFX_dev/linus_tree/Documentation/arch/powerpc/htm.rst: WARNING: document isn't included in any toctree^[[39;49;00m

-- 
~Randy