From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EA7EECAAD1 for ; Thu, 1 Sep 2022 07:56:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232674AbiIAH4y (ORCPT ); Thu, 1 Sep 2022 03:56:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232943AbiIAH4w (ORCPT ); Thu, 1 Sep 2022 03:56:52 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43DBEDF0A3 for ; Thu, 1 Sep 2022 00:56:51 -0700 (PDT) Received: from canpemm500004.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MJCtw1dkZzYd4d; Thu, 1 Sep 2022 15:52:24 +0800 (CST) Received: from [10.174.179.14] (10.174.179.14) by canpemm500004.china.huawei.com (7.192.104.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 1 Sep 2022 15:56:48 +0800 Subject: Re: [PATCH 08/13] ext4: factor out ext4_handle_csum() To: Jan Kara CC: , , , , References: <20220830120411.2371968-1-yanaijie@huawei.com> <20220830120411.2371968-9-yanaijie@huawei.com> <20220831115239.g4br24j2fi4e2k4x@quack3> From: Jason Yan Message-ID: <755d6df6-373e-75ae-ee4c-6e3583229ba5@huawei.com> Date: Thu, 1 Sep 2022 15:56:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20220831115239.g4br24j2fi4e2k4x@quack3> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.14] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500004.china.huawei.com (7.192.104.92) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 2022/8/31 19:52, Jan Kara wrote: > On Tue 30-08-22 20:04:06, Jason Yan wrote: >> Factor out ext4_handle_csum(). No functional change. >> >> Signed-off-by: Jason Yan >> --- >> fs/ext4/super.c | 83 +++++++++++++++++++++++++++---------------------- >> 1 file changed, 46 insertions(+), 37 deletions(-) >> >> diff --git a/fs/ext4/super.c b/fs/ext4/super.c >> index 9ee27472b802..96cf23787bba 100644 >> --- a/fs/ext4/super.c >> +++ b/fs/ext4/super.c >> @@ -4563,6 +4563,50 @@ static int ext4_encoding_init(struct super_block *sb, struct ext4_super_block *e >> return 0; >> } >> >> +static int ext4_handle_csum(struct super_block *sb, struct ext4_super_block *es) > > I'd rather call this function like ext4_init_metadata_csum(). > ext4_handle_csum() seems to vague to me. > Yes, much better. Thanks. > Otherwise the patch looks good to me. Feel free to add: > > Reviewed-by: Jan Kara > > Honza >