From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6270FC433EF for ; Wed, 16 Mar 2022 02:14:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236491AbiCPCPi (ORCPT ); Tue, 15 Mar 2022 22:15:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230250AbiCPCPg (ORCPT ); Tue, 15 Mar 2022 22:15:36 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84BE5642C for ; Tue, 15 Mar 2022 19:14:23 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id n15so676771plh.2 for ; Tue, 15 Mar 2022 19:14:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ZNODnXI0GG8OUMC7M4+T77BVFbBOatlGPAjnKZlPl/Q=; b=ZOQrJMqceyEbrmy847BDz8rO1Y7ZnIUAR1UKmO8JWim/2yHYSkd0RGOQNgl3lS7djl VXHzgd56aZvg0VcALGspo50mU6DS8jZQiAtNJPKTPDs65isMzIvlr3oDB8MxOf6yLhY1 GJEL2259m0OyEvh6jmyZRfa1sXptyo5neRJ6scuQlMLsqa1Libv1mQDlWXM3vBDwAsk7 ufH8IRXZ5oN1ZxNloqIZRP67SE5vj0LU+Fwjg1CqAnhM9+gvCa1l2MWwETlQwdyUl6UN 60eAmzY0BVbUfuHrkG7eC5SUsjUivvuHAHZXms2N+gFV2Xm9RdoSk3MH2Tpmk+ycRZfh 7sFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ZNODnXI0GG8OUMC7M4+T77BVFbBOatlGPAjnKZlPl/Q=; b=uTQNloKLqBlgqEnzAD9FFDVHfA3cmntufq1Gq95FBHQzb1o7Kj7afGpqjxNMX3MAXH 6cKamHpYyqdNK+YnIfPFObM/6IFfhzPvqBVAyW8Qfeqbq4UtfKc2uZrlcyCi2ULgld1N 1GwHokqNJn3uDexKDcTrwybGIzBe+hahBN0+u0YTbJQg5jx5EE9vLvDiGfeuaj9ogNoN eQfZZcW60FVL0HXlcc4+jwNAxgaQSjSOrPn1WciA+aCobji6mfmenp58wV7Z5WpFBW9G Npr8l8bCnRFRI8FL3H3pe7GrGfTH7C8uvrt7lGSjkJ7xDsKi2aUT8iBcBtayTq6kBwKH ZwCA== X-Gm-Message-State: AOAM532vk0qPzQhK9P5e1J7csfKO/BngCnQxbPifr54nRIsuriNB5mjN AaVpkVbeErs8XbKWUjnC/3/WkA== X-Google-Smtp-Source: ABdhPJyp4p2lLzdYUmpSbbIR7b7dCtVcRFuSn1KqZTrxASo7IhjJOMmDJruJHndLmJZMjfu9ufcvxg== X-Received: by 2002:a17:90a:4749:b0:1be:ea64:4348 with SMTP id y9-20020a17090a474900b001beea644348mr7674697pjg.231.1647396862810; Tue, 15 Mar 2022 19:14:22 -0700 (PDT) Received: from [192.168.254.17] ([50.39.160.154]) by smtp.gmail.com with ESMTPSA id a23-20020aa794b7000000b004f7d633a87asm467073pfl.57.2022.03.15.19.14.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Mar 2022 19:14:22 -0700 (PDT) Message-ID: <7c235bfa-d0c3-dd41-e8b2-746ce69fee1f@linaro.org> Date: Tue, 15 Mar 2022 19:14:21 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] ext4: check if offset+length is within a valid range in fallocate Content-Language: en-US To: kernel test robot , Theodore Ts'o Cc: kbuild-all@lists.01.org, Andreas Dilger , Ritesh Harjani , linux-ext4@vger.kernel.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+7a806094edd5d07ba029@syzkaller.appspotmail.com References: <20220315191545.187366-1-tadeusz.struk@linaro.org> <202203160919.MtfBk5N0-lkp@intel.com> From: Tadeusz Struk In-Reply-To: <202203160919.MtfBk5N0-lkp@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 3/15/22 18:22, kernel test robot wrote: > Hi Tadeusz, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on tytso-ext4/dev] > [also build test ERROR on linus/master v5.17-rc8 next-20220315] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url:https://github.com/0day-ci/linux/commits/Tadeusz-Struk/ext4-check-if-offset-length-is-within-a-valid-range-in-fallocate/20220316-031841 > base:https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev > config: arc-randconfig-r043-20220313 (https://download.01.org/0day-ci/archive/20220316/202203160919.MtfBk5N0-lkp@intel.com/config) > compiler: arc-elf-gcc (GCC) 11.2.0 > reproduce (this is a W=1 build): > wgethttps://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > #https://github.com/0day-ci/linux/commit/bc1fdc20f07523e970c9dea4f0fbabbc437fb0d5 > git remote add linux-reviewhttps://github.com/0day-ci/linux > git fetch --no-tags linux-review Tadeusz-Struk/ext4-check-if-offset-length-is-within-a-valid-range-in-fallocate/20220316-031841 > git checkout bc1fdc20f07523e970c9dea4f0fbabbc437fb0d5 > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash fs/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > fs/ext4/inode.c: In function 'ext4_punch_hole': >>> fs/ext4/inode.c:4002:50: error: 'struct ext4_sb_info' has no member named 's_blocksize' > 4002 | max_length = sbi->s_bitmap_maxbytes - sbi->s_blocksize; > | ^~ Thanks for report, but I've already sent v2: https://lore.kernel.org/linux-ext4/20220315215439.269122-1-tadeusz.struk@linaro.org -- Thanks, Tadeusz