From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>, linux-ext4@vger.kernel.org
Subject: Re: Change feature name from fname_encoding to casefold?
Date: Thu, 02 May 2019 17:46:33 -0400 [thread overview]
Message-ID: <85d0l0jzra.fsf@collabora.com> (raw)
In-Reply-To: <20190502205056.GA5193@magnolia> (Darrick J. Wong's message of "Thu, 2 May 2019 13:50:56 -0700")
"Darrick J. Wong" <darrick.wong@oracle.com> writes:
> On Thu, May 02, 2019 at 12:25:27PM -0400, Theodore Ts'o wrote:
>> Given how we've simplified how we handle Unicode --- in particular,
>> not doing any kind of normalization unless we are doing case-folding
>> compares, I think it will be more user-friendly if we rename the
>> feature from fname_encoding to casefold.
>
> TBH /me hadn't done enough reviewing even to notice the feature was
> named 'fname_encoding' (whatever that means -- encoded how?).
> IMHO 'casefold' is more descriptive about what the feature provides
> (folding case for directory name comparisons, right?)
>
This name was accurate until the v6 of the patches. In v7, we decided
to no longer apply file name encoding normalization system-wide during
lookups, which changed the semantics of this feature flag. By that
time, though, the name was already committed to e2fsprogs, so i didn't
bother to change it.
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2019-05-02 21:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-13 5:43 [PATCH e2fsprogs 00/10] case-insensitive feature updates Gabriel Krisman Bertazi
2019-04-13 5:43 ` [PATCH e2fsprogs 01/10] e2p: encoding: Fix default flags lookup Gabriel Krisman Bertazi
2019-04-28 19:04 ` Theodore Ts'o
2019-04-13 5:43 ` [PATCH e2fsprogs 02/10] ext2fs: Always attempt to load nls table when loading the filesystem Gabriel Krisman Bertazi
2019-04-28 19:06 ` Theodore Ts'o
2019-04-13 5:43 ` [PATCH e2fsprogs 04/10] ext2fs: nls: Fix potential null dereference in utf8nlookup Gabriel Krisman Bertazi
2019-04-28 19:11 ` Theodore Ts'o
2019-04-13 5:43 ` [PATCH e2fsprogs 05/10] ext2fs: nls: Merge sparse fixes from the kernel version Gabriel Krisman Bertazi
2019-04-28 19:12 ` Theodore Ts'o
2019-04-13 5:43 ` [PATCH e2fsprogs 07/10] ext2fs: Don't normalize names on -F directories Gabriel Krisman Bertazi
2019-04-28 20:45 ` Theodore Ts'o
2019-04-13 5:43 ` [PATCH e2fsprogs 08/10] ext2fs: nls: Drop normalization code Gabriel Krisman Bertazi
2019-04-28 20:48 ` Theodore Ts'o
2019-05-02 16:25 ` Change feature name from fname_encoding to casefold? Theodore Ts'o
2019-05-02 17:03 ` Gabriel Krisman Bertazi
2019-05-02 20:50 ` Darrick J. Wong
2019-05-02 21:46 ` Gabriel Krisman Bertazi [this message]
2019-04-13 5:43 ` [PATCH e2fsprogs 09/10] ext2fs: nls: Drop ascii NLS support Gabriel Krisman Bertazi
2019-04-28 20:52 ` Theodore Ts'o
2019-04-13 5:43 ` [PATCH e2fsprogs 10/10] ext4.5.in: Document design changes on the casefold attribute Gabriel Krisman Bertazi
2019-04-29 1:00 ` Theodore Ts'o
[not found] ` <20190413054317.7388-4-krisman@collabora.com>
2019-04-28 19:09 ` [PATCH e2fsprogs 03/10] ext2fs: nls: Convert NFKD -> NFD Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85d0l0jzra.fsf@collabora.com \
--to=krisman@collabora.com \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).