From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18FEAC43219 for ; Thu, 2 May 2019 21:46:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E61552063F for ; Thu, 2 May 2019 21:46:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726240AbfEBVqk (ORCPT ); Thu, 2 May 2019 17:46:40 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:42640 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726030AbfEBVqk (ORCPT ); Thu, 2 May 2019 17:46:40 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 91A0F26117F From: Gabriel Krisman Bertazi To: "Darrick J. Wong" Cc: "Theodore Ts'o" , linux-ext4@vger.kernel.org Subject: Re: Change feature name from fname_encoding to casefold? Organization: Collabora References: <20190413054317.7388-1-krisman@collabora.com> <20190413054317.7388-9-krisman@collabora.com> <20190502162527.GC25007@mit.edu> <20190502205056.GA5193@magnolia> Date: Thu, 02 May 2019 17:46:33 -0400 In-Reply-To: <20190502205056.GA5193@magnolia> (Darrick J. Wong's message of "Thu, 2 May 2019 13:50:56 -0700") Message-ID: <85d0l0jzra.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org "Darrick J. Wong" writes: > On Thu, May 02, 2019 at 12:25:27PM -0400, Theodore Ts'o wrote: >> Given how we've simplified how we handle Unicode --- in particular, >> not doing any kind of normalization unless we are doing case-folding >> compares, I think it will be more user-friendly if we rename the >> feature from fname_encoding to casefold. > > TBH /me hadn't done enough reviewing even to notice the feature was > named 'fname_encoding' (whatever that means -- encoded how?). > IMHO 'casefold' is more descriptive about what the feature provides > (folding case for directory name comparisons, right?) > This name was accurate until the v6 of the patches. In v7, we decided to no longer apply file name encoding normalization system-wide during lookups, which changed the semantics of this feature flag. By that time, though, the name was already committed to e2fsprogs, so i didn't bother to change it. -- Gabriel Krisman Bertazi